From: Al Viro <viro@zeniv.linux.org.uk>
To: Maxim Moskalets <maximmosk4@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Maxim Moskalets <Maxim.Moskalets@kaspersky.com>
Subject: Re: [PATCH 0/8] kernel: replace seq_puts by seq_putc
Date: Tue, 2 Apr 2024 01:57:50 +0100 [thread overview]
Message-ID: <20240402005750.GD538574@ZenIV> (raw)
In-Reply-To: <20240326184514.8478-1-Maxim.Moskalets@kaspersky.com>
On Tue, Mar 26, 2024 at 09:45:14PM +0300, Maxim Moskalets wrote:
> Using seq_putc for single characters is faster and more appropriate
> than seq_puts, since only one character is passed and there is no need
> to use a more powerful and less fast function.
Could we simply do this:
static inline void seq_puts(struct seq_file *m, const char *s)
{
if (__builtin_constant_p(*s) && s[0] && !s[1])
seq_putc(m, s[0]);
else
__seq_puts(m, s);
}
IIRC, __builtin_constant_p(*s) is true when s is a string literal.
Works for recent gcc and clang...
prev parent reply other threads:[~2024-04-02 0:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 18:45 [PATCH 0/8] kernel: replace seq_puts by seq_putc Maxim Moskalets
2024-03-26 18:45 ` [PATCH 1/8] bpf: " Maxim Moskalets
2024-03-26 18:45 ` [PATCH 2/8] cgroup: " Maxim Moskalets
2024-03-26 18:46 ` [PATCH 3/8] trace: " Maxim Moskalets
2024-03-26 18:46 ` [PATCH 4/8] module: " Maxim Moskalets
2024-03-26 18:47 ` [PATCH 5/8] sched: " Maxim Moskalets
2024-03-26 18:47 ` [PATCH 6/8] locking: " Maxim Moskalets
2024-03-26 18:47 ` [PATCH 7/8] time: " Maxim Moskalets
2024-03-26 18:47 ` [PATCH 8/8] kernel: " Maxim Moskalets
2024-04-02 0:57 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402005750.GD538574@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Maxim.Moskalets@kaspersky.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maximmosk4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox