From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4EABF9DF for ; Tue, 2 Apr 2024 06:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712037727; cv=none; b=KBGGgjZnaT/L5yEKQ+Yl64VRkbqTji0JjnpVhxw1Y6YJ+9w8wqr8pqojz3lQBIJqdcnPcVfu9cfbluepnWjoXOfFIIOPrACp/nMyT7NGwIn70lIyTzs0jQucEMAkDkuU71g0saPkqBwBX+LLFTeFIY1aRcTeFQL8aGJI8b6LBgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712037727; c=relaxed/simple; bh=EZ7Tqo7UTGR0nuXtZvOwSsONYxTeiw8Y1skKOcWnaac=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TrsZDK+QCrQzJRqAmpxClULhBEqFZl/b8SrzWk7F7Va59/hncWuCPGIr+XDtFvgY23wHUljYUSQ9AFjCbA4mocsbxOg5H6UMIi6bTnDbU5R812NDKfYRKNPuz0b8DgKfSPevqqo0J/ijJhv79mlIitA9TeFD0zayOtsqYIypMwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rQkARcJk; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rQkARcJk" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6e6f4ad4c57so3818866b3a.2 for ; Mon, 01 Apr 2024 23:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712037725; x=1712642525; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iWlujnh/UGREdcoJra5OBi+g0ocKuYapnQiOQEGk2r0=; b=rQkARcJkisEh0mhyqSZ7pLUrOJNW0Y5DDWWi+G5VxELaeDIFupXbm4PvZK8iwqAqip TuHS1kjCnaz5vQGm/DAEdzq2HJV7grFvrfAnoosVU8ZyOQqwckg2JfTOtREH6qN1AA4G 0pf8VxBpFTmAXN5P7pnTSPziv7hTIchEkLmAVWEg8qsvQVip6YL1/e5jhFbiioo4rmfy dgTZi/jkkEwiQ0ut7j1pCgOgFJnZPVWmM4uCCqaVwd3Qv3eTdDzjs8xYIa7y2xlG7nXb 0tH3NViWzrgwFUrxlzTpqDZSa8y+kbVuvwf8VcqBtyq18PE/Q/FKc4tl1dhpsxdOHVUS 6xbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712037725; x=1712642525; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iWlujnh/UGREdcoJra5OBi+g0ocKuYapnQiOQEGk2r0=; b=U6FVBkDr5FJiAuHoOdTSbdNgleBqf4hUdNF4h1tVAV9qtGKM/T1UMD8evYYZjb4+FL K8O04Xg7aWhZICH7Sd4bA4MD4Xo7RRfz+bvGs8zcb4j7c23jacudeSSA+sXkVejHP3zF qFem656ulC9axRT7pnBLVfLTA1gwvozWOcJOorpHthK3vHCjqRON6H9kXM6lWSvlYsey g5C/Hdu3VvKvubHuPSdI0jU0WxszdLPpVNYp1rKDFAJIf2YHA2i4aOn6r8IZ28slUkOb FY+Z+KWvZAeel0m3TbbPrFfNaJ662aXcPDtnTb4cRi26xgbQquwG+f9BZOTSqACEci3X HM8g== X-Forwarded-Encrypted: i=1; AJvYcCUCv7R3XQMNy4CwMZoF9OqStJHPIazfHkRz9EM6Z7Hs4/Zw2Qbv7z+AulAYapGeIcyfgugLDWcFXYB91bOp4Z9lwBjla/2/6WI+xsVn X-Gm-Message-State: AOJu0Yxp0BiS9UgjujCPpeq1DK/x0NrrzBFQLUtZ7sng1ZRYHb3Mg91C zK+vT/n5h9sPe42Ag2kMS/2w+pPqiA8WyuZMMaCxL0U/t3VMvOQS2slWkWRGH5sa4N2ZFvgb+8o = X-Google-Smtp-Source: AGHT+IEeY+bN8XZ6/697eZkIqE6Ld9gP5i46gSe5yu2qA3FvpRYE1YeXdblDII2YS6cwnxqeioQnpQ== X-Received: by 2002:a05:6a00:a83:b0:6ea:f444:341b with SMTP id b3-20020a056a000a8300b006eaf444341bmr10034781pfl.1.1712037725080; Mon, 01 Apr 2024 23:02:05 -0700 (PDT) Received: from thinkpad ([2406:7400:92:96cc:b954:3c38:e709:b65f]) by smtp.gmail.com with ESMTPSA id fm1-20020a056a002f8100b006ead0ade02fsm8912427pfb.29.2024.04.01.23.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Apr 2024 23:02:04 -0700 (PDT) Date: Tue, 2 Apr 2024 11:31:59 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marijn Suijten , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: Re: [PATCH v2] PCI: dwc: Use the correct sleep function in wait_for_link Message-ID: <20240402060159.GA7183@thinkpad> References: <20240215-topic-pci_sleep-v2-1-79334884546b@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240215-topic-pci_sleep-v2-1-79334884546b@linaro.org> On Wed, Mar 27, 2024 at 07:24:49PM +0100, Konrad Dybcio wrote: > According to [1], msleep should be used for large sleeps, such as the > 100-ish ms one in this function. Comply with the guide and use it. > > [1] https://www.kernel.org/doc/Documentation/timers/timers-howto.txt > > Signed-off-by: Konrad Dybcio Reviewed-by: Manivannan Sadhasivam - Mani > --- > Tested on Qualcomm SC8280XP CRD > --- > Changes in v2: > - Rename the define > - Sleep for 90ms (the lower boundary) instead of 100 > - Link to v1: https://lore.kernel.org/r/20240215-topic-pci_sleep-v1-1-7ac79ac9739a@linaro.org > --- > drivers/pci/controller/dwc/pcie-designware.c | 2 +- > drivers/pci/controller/dwc/pcie-designware.h | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 250cf7f40b85..62915e4b2ebd 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -655,7 +655,7 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci) > if (dw_pcie_link_up(pci)) > break; > > - usleep_range(LINK_WAIT_USLEEP_MIN, LINK_WAIT_USLEEP_MAX); > + msleep(LINK_WAIT_SLEEP_MS); > } > > if (retries >= LINK_WAIT_MAX_RETRIES) { > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index 26dae4837462..b17e8ff54f55 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -63,8 +63,7 @@ > > /* Parameters for the waiting for link up routine */ > #define LINK_WAIT_MAX_RETRIES 10 > -#define LINK_WAIT_USLEEP_MIN 90000 > -#define LINK_WAIT_USLEEP_MAX 100000 > +#define LINK_WAIT_SLEEP_MS 90 > > /* Parameters for the waiting for iATU enabled routine */ > #define LINK_WAIT_MAX_IATU_RETRIES 5 > > --- > base-commit: 26074e1be23143b2388cacb36166766c235feb7c > change-id: 20240215-topic-pci_sleep-368108a1fb6f > > Best regards, > -- > Konrad Dybcio > -- மணிவண்ணன் சதாசிவம்