From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Michael Walle <mwalle@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] nvmem: layouts: store owner from modules with nvmem_layout_driver_register()
Date: Tue, 2 Apr 2024 09:16:44 +0200 [thread overview]
Message-ID: <20240402091644.35c7dac6@xps-13> (raw)
In-Reply-To: <20240329-module-owner-nvmem-v1-1-d700685f08e1@linaro.org>
Hi Krzysztof,
krzysztof.kozlowski@linaro.org wrote on Fri, 29 Mar 2024 17:13:35 +0100:
> Modules registering driver with nvmem_layout_driver_register() might
> forget to set .owner field. The field is used by some of other kernel
> parts for reference counting (try_module_get()), so it is expected that
> drivers will set it.
>
> Solve the problem by moving this task away from the drivers to the core
> code, just like we did for platform_driver in
> commit 9447057eaff8 ("platform_device: use a macro instead of
> platform_driver_register").
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2024-04-02 7:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 16:13 [PATCH 0/3] nvmem: layouts: store owner from modules with nvmem_layout_driver_register() Krzysztof Kozlowski
2024-03-29 16:13 ` [PATCH 1/3] " Krzysztof Kozlowski
2024-04-02 7:16 ` Miquel Raynal [this message]
2024-04-02 8:37 ` Michael Walle
2024-03-29 16:13 ` [PATCH 2/3] nvmem: layouts: onie-tlv: drop driver owner initialization Krzysztof Kozlowski
2024-04-02 7:16 ` Miquel Raynal
2024-04-02 8:37 ` Michael Walle
2024-03-29 16:13 ` [PATCH 3/3] nvmem: layouts: sl28vpd: " Krzysztof Kozlowski
2024-04-02 7:17 ` Miquel Raynal
2024-04-02 8:38 ` Michael Walle
2024-04-11 10:01 ` [PATCH 0/3] nvmem: layouts: store owner from modules with nvmem_layout_driver_register() Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402091644.35c7dac6@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwalle@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox