public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Michael Walle <mwalle@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] nvmem: layouts: sl28vpd: drop driver owner initialization
Date: Tue, 2 Apr 2024 09:17:23 +0200	[thread overview]
Message-ID: <20240402091723.1923c13c@xps-13> (raw)
In-Reply-To: <20240329-module-owner-nvmem-v1-3-d700685f08e1@linaro.org>

Hi Krzysztof,

krzysztof.kozlowski@linaro.org wrote on Fri, 29 Mar 2024 17:13:37 +0100:

> Core in nvmem_layout_driver_register() already sets the .owner, so
> driver does not need to.
> 

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  drivers/nvmem/layouts/sl28vpd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/nvmem/layouts/sl28vpd.c b/drivers/nvmem/layouts/sl28vpd.c
> index 53fa50f17dca..e93b020b0836 100644
> --- a/drivers/nvmem/layouts/sl28vpd.c
> +++ b/drivers/nvmem/layouts/sl28vpd.c
> @@ -156,7 +156,6 @@ MODULE_DEVICE_TABLE(of, sl28vpd_of_match_table);
>  
>  static struct nvmem_layout_driver sl28vpd_layout = {
>  	.driver = {
> -		.owner = THIS_MODULE,
>  		.name = "kontron-sl28vpd-layout",
>  		.of_match_table = sl28vpd_of_match_$

Thanks,
Miquèl

  reply	other threads:[~2024-04-02  7:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 16:13 [PATCH 0/3] nvmem: layouts: store owner from modules with nvmem_layout_driver_register() Krzysztof Kozlowski
2024-03-29 16:13 ` [PATCH 1/3] " Krzysztof Kozlowski
2024-04-02  7:16   ` Miquel Raynal
2024-04-02  8:37   ` Michael Walle
2024-03-29 16:13 ` [PATCH 2/3] nvmem: layouts: onie-tlv: drop driver owner initialization Krzysztof Kozlowski
2024-04-02  7:16   ` Miquel Raynal
2024-04-02  8:37   ` Michael Walle
2024-03-29 16:13 ` [PATCH 3/3] nvmem: layouts: sl28vpd: " Krzysztof Kozlowski
2024-04-02  7:17   ` Miquel Raynal [this message]
2024-04-02  8:38   ` Michael Walle
2024-04-11 10:01 ` [PATCH 0/3] nvmem: layouts: store owner from modules with nvmem_layout_driver_register() Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402091723.1923c13c@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mwalle@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox