From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Jiri Slaby <jirislaby@kernel.org>
Subject: [PATCH v1 03/16] serial: max3100: Fix bitwise types
Date: Tue, 2 Apr 2024 18:38:09 +0300 [thread overview]
Message-ID: <20240402154219.3583679-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240402154219.3583679-1-andriy.shevchenko@linux.intel.com>
Sparse is not happy about misuse of bitwise types:
.../max3100.c:194:13: warning: incorrect type in assignment (different base types)
.../max3100.c:194:13: expected unsigned short [addressable] [usertype] etx
.../max3100.c:194:13: got restricted __be16 [usertype]
.../max3100.c:202:15: warning: cast to restricted __be16
Fix this by choosing proper types for the respective variables.
Fixes: 7831d56b0a35 ("tty: MAX3100")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/max3100.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
index efe26f6d5ebf..3c68b8e1a226 100644
--- a/drivers/tty/serial/max3100.c
+++ b/drivers/tty/serial/max3100.c
@@ -45,6 +45,9 @@
#include <linux/freezer.h>
#include <linux/tty.h>
#include <linux/tty_flip.h>
+#include <linux/types.h>
+
+#include <asm/unaligned.h>
#include <linux/serial_max3100.h>
@@ -191,7 +194,7 @@ static void max3100_timeout(struct timer_list *t)
static int max3100_sr(struct max3100_port *s, u16 tx, u16 *rx)
{
struct spi_message message;
- u16 etx, erx;
+ __be16 etx, erx;
int status;
struct spi_transfer tran = {
.tx_buf = &etx,
--
2.43.0.rc1.1.gbec44491f096
next prev parent reply other threads:[~2024-04-02 15:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 15:38 [PATCH v1 00/16] serial: max3100: Put into shape Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 01/16] serial: max3100: Lock port->lock when calling uart_handle_cts_change() Andy Shevchenko
2024-04-02 17:07 ` Hugo Villeneuve
2024-04-02 17:14 ` Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 02/16] serial: max3100: Update uart_driver_registered on driver removal Andy Shevchenko
2024-04-02 17:18 ` Hugo Villeneuve
2024-04-02 17:31 ` Andy Shevchenko
2024-04-02 17:37 ` Hugo Villeneuve
2024-04-02 15:38 ` Andy Shevchenko [this message]
2024-04-02 15:38 ` [PATCH v1 04/16] serial: max3100: Make struct plat_max3100 local Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 05/16] serial: max3100: Remove custom HW shutdown support Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 06/16] serial: max3100: Replace custom polling timeout with standard one Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 07/16] serial: max3100: Enable TIOCM_LOOP Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 08/16] serial: max3100: Get crystal frequency via device property Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 09/16] serial: max3100: Remove duplicating irq field Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 10/16] serial: max3100: Switch to use dev_err_probe() Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 11/16] serial: max3100: Replace MODULE_ALIAS() with respective ID tables Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 12/16] serial: max3100: Switch to DEFINE_SIMPLE_DEV_PM_OPS() Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 13/16] serial: max3100: Extract to_max3100_port() helper macro Andy Shevchenko
2024-04-02 17:32 ` Hugo Villeneuve
2024-04-02 17:40 ` Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 14/16] serial: max3100: Remove unneeded forward declaration Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 15/16] serial: max3100: Sort headers Andy Shevchenko
2024-04-02 15:38 ` [PATCH v1 16/16] serial: max3100: Update Kconfig entry Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402154219.3583679-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox