* [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe()
@ 2024-04-02 10:40 Harshit Mogalapalli
2024-04-02 14:03 ` Boris Brezillon
2024-04-03 7:15 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Harshit Mogalapalli @ 2024-04-02 10:40 UTC (permalink / raw)
To: Boris Brezillon, Steven Price, Liviu Dudau, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter,
Grant Likely, dri-devel, linux-kernel
Cc: dan.carpenter, kernel-janitors, error27, harshit.m.mogalapalli
The devm_drm_dev_alloc() function returns error pointers.
Update the error handling to check for error pointers instead of NULL.
Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
---
This is spotted by smatch and the patch is only compile tested
---
drivers/gpu/drm/panthor/panthor_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
index 11b3ccd58f85..1b588b37db98 100644
--- a/drivers/gpu/drm/panthor/panthor_drv.c
+++ b/drivers/gpu/drm/panthor/panthor_drv.c
@@ -1385,7 +1385,7 @@ static int panthor_probe(struct platform_device *pdev)
ptdev = devm_drm_dev_alloc(&pdev->dev, &panthor_drm_driver,
struct panthor_device, base);
- if (!ptdev)
+ if (IS_ERR(ptdev))
return -ENOMEM;
platform_set_drvdata(pdev, ptdev);
--
2.39.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe()
2024-04-02 10:40 [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe() Harshit Mogalapalli
@ 2024-04-02 14:03 ` Boris Brezillon
2024-04-03 7:15 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2024-04-02 14:03 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: Steven Price, Liviu Dudau, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Grant Likely,
dri-devel, linux-kernel, dan.carpenter, kernel-janitors, error27
On Tue, 2 Apr 2024 03:40:40 -0700
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:
> The devm_drm_dev_alloc() function returns error pointers.
> Update the error handling to check for error pointers instead of NULL.
>
> Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> This is spotted by smatch and the patch is only compile tested
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 11b3ccd58f85..1b588b37db98 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1385,7 +1385,7 @@ static int panthor_probe(struct platform_device *pdev)
>
> ptdev = devm_drm_dev_alloc(&pdev->dev, &panthor_drm_driver,
> struct panthor_device, base);
> - if (!ptdev)
> + if (IS_ERR(ptdev))
> return -ENOMEM;
>
> platform_set_drvdata(pdev, ptdev);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe()
2024-04-02 10:40 [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe() Harshit Mogalapalli
2024-04-02 14:03 ` Boris Brezillon
@ 2024-04-03 7:15 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2024-04-03 7:15 UTC (permalink / raw)
To: Harshit Mogalapalli
Cc: Steven Price, Liviu Dudau, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Grant Likely,
dri-devel, linux-kernel, dan.carpenter, kernel-janitors, error27
On Tue, 2 Apr 2024 03:40:40 -0700
Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote:
> The devm_drm_dev_alloc() function returns error pointers.
> Update the error handling to check for error pointers instead of NULL.
>
> Fixes: 4bdca1150792 ("drm/panthor: Add the driver frontend block")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Queued to drm-misc-next.
Thanks,
Boris
> ---
> This is spotted by smatch and the patch is only compile tested
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 11b3ccd58f85..1b588b37db98 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1385,7 +1385,7 @@ static int panthor_probe(struct platform_device *pdev)
>
> ptdev = devm_drm_dev_alloc(&pdev->dev, &panthor_drm_driver,
> struct panthor_device, base);
> - if (!ptdev)
> + if (IS_ERR(ptdev))
> return -ENOMEM;
>
> platform_set_drvdata(pdev, ptdev);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-03 7:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-02 10:40 [PATCH] drm/panthor: Fix NULL vs IS_ERR() bug in panthor_probe() Harshit Mogalapalli
2024-04-02 14:03 ` Boris Brezillon
2024-04-03 7:15 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox