From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70AB7143869 for ; Wed, 3 Apr 2024 12:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712146337; cv=none; b=SWXJFiG0OpMeC3234lf4dDb6E5e2LnQsepDqxKrAb+TeMUJoF1tMrrtpusSRXvcttW7ghDz6fTuMETqFcb0z7yFIDAH4WkAoqB2KpoJQKjv79xhXqfUn6YFXVfTMQsfCNok/515T52VMkPv68wiNR57aTopUIdHwj2De78jXVoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712146337; c=relaxed/simple; bh=brj4KkxiuzB/cTaKYABW0xgl0MAd+mDFIIil3DRUwDQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RsARC/SVe+kUeYDHh61n3ndJ/mhS9y8xFlNr9s+CnZQA8ArUvpC86XczCYmmrl6eceDgD9+D+2YFVeL9comJKcRBYUB1sWf8IcqOcxh5YgYDakmH4EtnnHu7MZRFmQbWzI0R/fKxffOia2igMcj9QPAwTh+ZzRGT5Daw0pPIBug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ecKGVZdU; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ecKGVZdU" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1e27c303573so12987225ad.3 for ; Wed, 03 Apr 2024 05:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712146336; x=1712751136; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=BruioLBkFU/4Gr8BIJ48KpNZhiGvLxDKNkifr5Fva6A=; b=ecKGVZdU8bhNPOpAvLxziCRXwbUZUX8cMZsuid5A/T/ooIhW/535QZ/1NlopqlyS9C dCx4gdliNUeIHps69L+yl7pi+6fMraB0ek0+OmtX5Otla7doi6uEyKpBTNSTi63f5dA8 docrsXAbau2BcyALZwP1Bkj6DExFqjBZ06elIc4qLhnBO/iUXGe0MpfPFdJndxKsaRiQ AZQYeFBp4BJMaAQFx1WUvW0Vzhjym5bZ26pxkBZmPBzdUjPzQimi+Uoq0X0HOLTX2ehr qDui1+k6p5UTfYpQSYT0YvH+xX91jIqVfG4t47NqubEqn8XK6PFv6yhFnDGj42QoGCHb lYAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712146336; x=1712751136; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BruioLBkFU/4Gr8BIJ48KpNZhiGvLxDKNkifr5Fva6A=; b=wzD7PhbEplFg7mf7AWiBwAcmUpijEYYWfLgYq2FOlxjfrOnfledOJ+OdhLyuBXnOBm YAY6XFOa9FFW57V9DrIGG1S4eUmcqbhcLxAWxgB5jM2/eqPUTeVZOD2TM/W5m0DPCN2g z+umhx1GXdsBWiQR7BhvXv4+RnOYB/+V5iXcusxvmM5o12aR/PFNI58zikr9LKmsU8cT 287lhV4/qso1zqglxBagL5wQEEWOFdYgT44G3tguwy9Nf2auY4KMJGHTxBAoUKYjC1aF Tw9AIp+Ti2/FyWPMjUM7Jzn3y84B/ALfY8URGgygFOjtOU0CinybvN16TzWsXFIF+c2E bfcA== X-Forwarded-Encrypted: i=1; AJvYcCV2DoGeX+ZhxjOl086Hk1QePIVtHWNqCsymbABR1igMKZXvbfouLYqZS5v1Q3Po1ZVXIsdpTTMEj9H57KgGSrYvPaUgtIVPXoH+K3Kl X-Gm-Message-State: AOJu0Yz6wOyhH8Qd9txkP6n39jFTOd5CckYUG+ID4jtR6zCafvjBfDyH 4Uu175QSY/p92vT2s8HXqt3/caJNPZDvTCl+wZxD77gqZY4xZkV33AAn15knug== X-Google-Smtp-Source: AGHT+IG9NG4VxPu4A8bz2c/Sxzuq1eBAlbG1/HgvyTLPbTBK7p4H9R0/kt20ykZuifHv/l0Kuczj7A== X-Received: by 2002:a17:902:784d:b0:1e2:7aaf:65bc with SMTP id e13-20020a170902784d00b001e27aaf65bcmr3297593pln.34.1712146335487; Wed, 03 Apr 2024 05:12:15 -0700 (PDT) Received: from thinkpad ([103.28.246.48]) by smtp.gmail.com with ESMTPSA id j8-20020a170902da8800b001e205884ac6sm13072185plx.20.2024.04.03.05.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 05:12:15 -0700 (PDT) Date: Wed, 3 Apr 2024 17:42:10 +0530 From: Manivannan Sadhasivam To: Konrad Dybcio Cc: Bjorn Andersson , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Pundir Subject: Re: [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5 Message-ID: <20240403121210.GJ25309@thinkpad> References: <20240401-ufs-icc-fix-v1-1-3bac41bdfa7a@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 02, 2024 at 04:48:40PM +0200, Konrad Dybcio wrote: > On 1.04.2024 5:09 PM, Manivannan Sadhasivam wrote: > > These entries are necessary to scale the interconnect bandwidth while > > operating in Gear 5. > > > > Cc: Amit Pundir > > Fixes: 03ce80a1bb86 ("scsi: ufs: qcom: Add support for scaling interconnects") > > Signed-off-by: Manivannan Sadhasivam > > --- > > Skimming through the code, could ufs_qcom_get_bw_table use a > WARN_ON_ONCE(nullcheck)? > > FWIW, this change looks sane (without checking the numbers) > This really makes sense. Will add a patch in v2. - Mani -- மணிவண்ணன் சதாசிவம்