* [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5
@ 2024-04-01 15:09 Manivannan Sadhasivam
2024-04-02 14:44 ` Amit Pundir
2024-04-02 14:48 ` Konrad Dybcio
0 siblings, 2 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2024-04-01 15:09 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-arm-msm, linux-scsi, linux-kernel, Amit Pundir,
Manivannan Sadhasivam
These entries are necessary to scale the interconnect bandwidth while
operating in Gear 5.
Cc: Amit Pundir <amit.pundir@linaro.org>
Fixes: 03ce80a1bb86 ("scsi: ufs: qcom: Add support for scaling interconnects")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/ufs/host/ufs-qcom.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 8d68bd21ae73..696540ca835e 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -47,7 +47,7 @@ enum {
TSTBUS_MAX,
};
-#define QCOM_UFS_MAX_GEAR 4
+#define QCOM_UFS_MAX_GEAR 5
#define QCOM_UFS_MAX_LANE 2
enum {
@@ -67,26 +67,32 @@ static const struct __ufs_qcom_bw_table {
[MODE_PWM][UFS_PWM_G2][UFS_LANE_1] = { 1844, 1000 },
[MODE_PWM][UFS_PWM_G3][UFS_LANE_1] = { 3688, 1000 },
[MODE_PWM][UFS_PWM_G4][UFS_LANE_1] = { 7376, 1000 },
+ [MODE_PWM][UFS_PWM_G5][UFS_LANE_1] = { 14752, 1000 },
[MODE_PWM][UFS_PWM_G1][UFS_LANE_2] = { 1844, 1000 },
[MODE_PWM][UFS_PWM_G2][UFS_LANE_2] = { 3688, 1000 },
[MODE_PWM][UFS_PWM_G3][UFS_LANE_2] = { 7376, 1000 },
[MODE_PWM][UFS_PWM_G4][UFS_LANE_2] = { 14752, 1000 },
+ [MODE_PWM][UFS_PWM_G5][UFS_LANE_2] = { 29504, 1000 },
[MODE_HS_RA][UFS_HS_G1][UFS_LANE_1] = { 127796, 1000 },
[MODE_HS_RA][UFS_HS_G2][UFS_LANE_1] = { 255591, 1000 },
[MODE_HS_RA][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
[MODE_HS_RA][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
+ [MODE_HS_RA][UFS_HS_G5][UFS_LANE_1] = { 5836800, 409600 },
[MODE_HS_RA][UFS_HS_G1][UFS_LANE_2] = { 255591, 1000 },
[MODE_HS_RA][UFS_HS_G2][UFS_LANE_2] = { 511181, 1000 },
[MODE_HS_RA][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
[MODE_HS_RA][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
+ [MODE_HS_RA][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
[MODE_HS_RB][UFS_HS_G1][UFS_LANE_1] = { 149422, 1000 },
[MODE_HS_RB][UFS_HS_G2][UFS_LANE_1] = { 298189, 1000 },
[MODE_HS_RB][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
[MODE_HS_RB][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
+ [MODE_HS_RB][UFS_HS_G5][UFS_LANE_1] = { 5836800, 409600 },
[MODE_HS_RB][UFS_HS_G1][UFS_LANE_2] = { 298189, 1000 },
[MODE_HS_RB][UFS_HS_G2][UFS_LANE_2] = { 596378, 1000 },
[MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
[MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
+ [MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
[MODE_MAX][0][0] = { 7643136, 307200 },
};
---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240401-ufs-icc-fix-123c7ca1be45
Best regards,
--
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5
2024-04-01 15:09 [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5 Manivannan Sadhasivam
@ 2024-04-02 14:44 ` Amit Pundir
2024-04-02 14:48 ` Konrad Dybcio
1 sibling, 0 replies; 4+ messages in thread
From: Amit Pundir @ 2024-04-02 14:44 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Bjorn Andersson, Konrad Dybcio, James E.J. Bottomley,
Martin K. Petersen, linux-arm-msm, linux-scsi, linux-kernel
On Mon, 1 Apr 2024 at 20:39, Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> These entries are necessary to scale the interconnect bandwidth while
> operating in Gear 5.
This fixes the UFS breakage we see on SM8550-HDK.
Tested-by: Amit Pundir <amit.pundir@linaro.org>
Regards,
Amit Pundir
>
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Fixes: 03ce80a1bb86 ("scsi: ufs: qcom: Add support for scaling interconnects")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/ufs/host/ufs-qcom.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8d68bd21ae73..696540ca835e 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -47,7 +47,7 @@ enum {
> TSTBUS_MAX,
> };
>
> -#define QCOM_UFS_MAX_GEAR 4
> +#define QCOM_UFS_MAX_GEAR 5
> #define QCOM_UFS_MAX_LANE 2
>
> enum {
> @@ -67,26 +67,32 @@ static const struct __ufs_qcom_bw_table {
> [MODE_PWM][UFS_PWM_G2][UFS_LANE_1] = { 1844, 1000 },
> [MODE_PWM][UFS_PWM_G3][UFS_LANE_1] = { 3688, 1000 },
> [MODE_PWM][UFS_PWM_G4][UFS_LANE_1] = { 7376, 1000 },
> + [MODE_PWM][UFS_PWM_G5][UFS_LANE_1] = { 14752, 1000 },
> [MODE_PWM][UFS_PWM_G1][UFS_LANE_2] = { 1844, 1000 },
> [MODE_PWM][UFS_PWM_G2][UFS_LANE_2] = { 3688, 1000 },
> [MODE_PWM][UFS_PWM_G3][UFS_LANE_2] = { 7376, 1000 },
> [MODE_PWM][UFS_PWM_G4][UFS_LANE_2] = { 14752, 1000 },
> + [MODE_PWM][UFS_PWM_G5][UFS_LANE_2] = { 29504, 1000 },
> [MODE_HS_RA][UFS_HS_G1][UFS_LANE_1] = { 127796, 1000 },
> [MODE_HS_RA][UFS_HS_G2][UFS_LANE_1] = { 255591, 1000 },
> [MODE_HS_RA][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
> [MODE_HS_RA][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
> + [MODE_HS_RA][UFS_HS_G5][UFS_LANE_1] = { 5836800, 409600 },
> [MODE_HS_RA][UFS_HS_G1][UFS_LANE_2] = { 255591, 1000 },
> [MODE_HS_RA][UFS_HS_G2][UFS_LANE_2] = { 511181, 1000 },
> [MODE_HS_RA][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
> [MODE_HS_RA][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
> + [MODE_HS_RA][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
> [MODE_HS_RB][UFS_HS_G1][UFS_LANE_1] = { 149422, 1000 },
> [MODE_HS_RB][UFS_HS_G2][UFS_LANE_1] = { 298189, 1000 },
> [MODE_HS_RB][UFS_HS_G3][UFS_LANE_1] = { 1492582, 102400 },
> [MODE_HS_RB][UFS_HS_G4][UFS_LANE_1] = { 2915200, 204800 },
> + [MODE_HS_RB][UFS_HS_G5][UFS_LANE_1] = { 5836800, 409600 },
> [MODE_HS_RB][UFS_HS_G1][UFS_LANE_2] = { 298189, 1000 },
> [MODE_HS_RB][UFS_HS_G2][UFS_LANE_2] = { 596378, 1000 },
> [MODE_HS_RB][UFS_HS_G3][UFS_LANE_2] = { 1492582, 204800 },
> [MODE_HS_RB][UFS_HS_G4][UFS_LANE_2] = { 2915200, 409600 },
> + [MODE_HS_RB][UFS_HS_G5][UFS_LANE_2] = { 5836800, 819200 },
> [MODE_MAX][0][0] = { 7643136, 307200 },
> };
>
>
> ---
> base-commit: 4cece764965020c22cff7665b18a012006359095
> change-id: 20240401-ufs-icc-fix-123c7ca1be45
>
> Best regards,
> --
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5
2024-04-01 15:09 [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5 Manivannan Sadhasivam
2024-04-02 14:44 ` Amit Pundir
@ 2024-04-02 14:48 ` Konrad Dybcio
2024-04-03 12:12 ` Manivannan Sadhasivam
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2024-04-02 14:48 UTC (permalink / raw)
To: Manivannan Sadhasivam, Bjorn Andersson, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-arm-msm, linux-scsi, linux-kernel, Amit Pundir
On 1.04.2024 5:09 PM, Manivannan Sadhasivam wrote:
> These entries are necessary to scale the interconnect bandwidth while
> operating in Gear 5.
>
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Fixes: 03ce80a1bb86 ("scsi: ufs: qcom: Add support for scaling interconnects")
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
Skimming through the code, could ufs_qcom_get_bw_table use a
WARN_ON_ONCE(nullcheck)?
FWIW, this change looks sane (without checking the numbers)
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5
2024-04-02 14:48 ` Konrad Dybcio
@ 2024-04-03 12:12 ` Manivannan Sadhasivam
0 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2024-04-03 12:12 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Bjorn Andersson, James E.J. Bottomley, Martin K. Petersen,
linux-arm-msm, linux-scsi, linux-kernel, Amit Pundir
On Tue, Apr 02, 2024 at 04:48:40PM +0200, Konrad Dybcio wrote:
> On 1.04.2024 5:09 PM, Manivannan Sadhasivam wrote:
> > These entries are necessary to scale the interconnect bandwidth while
> > operating in Gear 5.
> >
> > Cc: Amit Pundir <amit.pundir@linaro.org>
> > Fixes: 03ce80a1bb86 ("scsi: ufs: qcom: Add support for scaling interconnects")
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
>
> Skimming through the code, could ufs_qcom_get_bw_table use a
> WARN_ON_ONCE(nullcheck)?
>
> FWIW, this change looks sane (without checking the numbers)
>
This really makes sense. Will add a patch in v2.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-03 12:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-01 15:09 [PATCH] scsi: ufs: qcom: Add missing interconnect bandwidth values for Gear 5 Manivannan Sadhasivam
2024-04-02 14:44 ` Amit Pundir
2024-04-02 14:48 ` Konrad Dybcio
2024-04-03 12:12 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox