From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: jgross@suse.com,tglx@linutronix.de,x86@kernel.org,bp@alien8.de,Dave
Hansen <dave.hansen@linux.intel.com>
Subject: [PATCH 2/4] perf/x86/ibs: Use CPUID region helper
Date: Wed, 03 Apr 2024 08:35:11 -0700 [thread overview]
Message-ID: <20240403153511.75CB9DA0@davehans-spike.ostc.intel.com> (raw)
In-Reply-To: <20240403153508.7328E749@davehans-spike.ostc.intel.com>
From: Dave Hansen <dave.hansen@linux.intel.com>
IBS details are enumerated in an extended CPUID leaf. But
the support has an open-coded CPUID region check. Use the
new helper to trim down the code.
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
--
Note: this cleanup could take another form:
if (boot_cpu_data->extended_cpuid_level >= IBS_CPUID_FEATURES)
caps = cpuid_eax(IBS_CPUID_FEATURES);
that would be one fewer CPUID invocations, but one more
line of code.
---
b/arch/x86/events/amd/ibs.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff -puN arch/x86/events/amd/ibs.c~ibs-region-helpers arch/x86/events/amd/ibs.c
--- a/arch/x86/events/amd/ibs.c~ibs-region-helpers 2024-04-02 15:22:59.262912595 -0700
+++ b/arch/x86/events/amd/ibs.c 2024-04-02 15:22:59.262912595 -0700
@@ -1278,18 +1278,13 @@ static __init int perf_event_ibs_init(vo
static __init u32 __get_ibs_caps(void)
{
- u32 caps;
- unsigned int max_level;
+ u32 caps = 0;
if (!boot_cpu_has(X86_FEATURE_IBS))
return 0;
- /* check IBS cpuid feature flags */
- max_level = cpuid_eax(0x80000000);
- if (max_level < IBS_CPUID_FEATURES)
- return IBS_CAPS_DEFAULT;
+ get_cpuid_region_leaf(IBS_CPUID_FEATURES, CPUID_EAX, &caps);
- caps = cpuid_eax(IBS_CPUID_FEATURES);
if (!(caps & IBS_CAPS_AVAIL))
/* cpuid flags not valid */
return IBS_CAPS_DEFAULT;
_
next prev parent reply other threads:[~2024-04-03 15:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 15:35 [PATCH 0/4] [v2] x86: Add CPUID region helper and clarify Xen startup Dave Hansen
2024-04-03 15:35 ` [PATCH 1/4] x86/cpu: Add and use new CPUID region helper Dave Hansen
2024-04-04 9:04 ` Jürgen Groß
2024-04-08 16:25 ` Borislav Petkov
2024-04-03 15:35 ` Dave Hansen [this message]
2024-04-16 15:12 ` [PATCH 2/4] perf/x86/ibs: Use " Borislav Petkov
2024-04-16 15:23 ` Dave Hansen
2024-04-16 17:48 ` Borislav Petkov
2024-04-18 12:05 ` Robert Richter
2024-04-22 17:20 ` Borislav Petkov
2024-04-22 20:09 ` Robert Richter
2024-04-22 20:41 ` Borislav Petkov
2024-04-22 21:30 ` Robert Richter
2024-04-22 21:45 ` Borislav Petkov
2024-04-23 7:45 ` Robert Richter
2024-04-23 8:33 ` Borislav Petkov
2024-04-03 15:35 ` [PATCH 3/4] x86/boot: Explicitly pass NX enabling status Dave Hansen
2024-04-04 10:33 ` Jürgen Groß
2024-04-03 15:35 ` [PATCH 4/4] x86/xen: Enumerate NX from CPUID directly Dave Hansen
2024-04-04 10:44 ` Jürgen Groß
2024-04-04 14:24 ` Dave Hansen
2024-04-04 15:05 ` Sean Christopherson
2024-04-22 17:44 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2024-03-22 17:56 [PATCH 0/4] x86: Add CPUID region helper and clarify Xen startup Dave Hansen
2024-03-22 17:56 ` [PATCH 2/4] perf/x86/ibs: Use CPUID region helper Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403153511.75CB9DA0@davehans-spike.ostc.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=bp@alien8.de \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox