From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 776BD15D5C7; Wed, 3 Apr 2024 17:18:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712164723; cv=none; b=dkSog3o+Kz8ZvfeSC303MZkvbb5kxnyEKYYLQsngzDO7BILC7nJ6rhyLT5Nbdu+HUepYCebxPgGc11YxZm6bs4NCM97fY7Fx1t5Jfo7TSZAXhujaJGN8qfFtZOzuDYa3IBMAgUommnU+b59b4idYGOUwEvBtz9FTKOWFRcOU2SQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712164723; c=relaxed/simple; bh=KGum2UiFM/XeeIttcKMIY9uAmatsd+1YLL7DOdMp7+8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lv88jmh860iZUQEn7JXAzffuji8CrnLERaR7QDb/q2fvvO3WAt6jcicZ/jryMrgXTX0EG81qX8VFdLz1xXnxTmkDUkNr/41oT+1wg49/5P+keVdDB3f4p5Og9KO92DI36stz6tSkg0ZJdsmXYz/obzjuWYb+2IKdp4q+qRBcNXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HJXyF+5Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HJXyF+5Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7744DC43390; Wed, 3 Apr 2024 17:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712164723; bh=KGum2UiFM/XeeIttcKMIY9uAmatsd+1YLL7DOdMp7+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HJXyF+5YkdCqSBbWXvkxn7gQibcn1ExL5RRvMvdzYsuU2KzdwjSJv6QB4WXDn/Dpw qaDkqXVlbJsANIBOJ1V0XelNCjbMbSVXZkaaSwbhMbaeDilqAhkkLQM8V3dAFhGTru Z9KrfuqChsmuEFwzjdMMaNGE/gxBeGXHZIgh68LXTQXlmRoR6Y+A8Sb9MHkrP7j67e fSSBtHmtAQVIK6dZMUWpSapr1xhruYRHE5xcGSrID7JC78Y0iX5Lh2ZxRYXZWHMqcy +6b11bnkCyP4JhwZqIu3Z/vrVknqAyhev9ZvNi1yAgCnsQuPP/VMZh0kz26Vg/H8S3 p+REP+OSoVi8A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Aleksandr Burakov , Helge Deller , Sasha Levin , FlorianSchandinat@gmx.de, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.6 14/20] fbdev: viafb: fix typo in hw_bitblt_1 and hw_bitblt_2 Date: Wed, 3 Apr 2024 13:17:55 -0400 Message-ID: <20240403171815.342668-14-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240403171815.342668-1-sashal@kernel.org> References: <20240403171815.342668-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.24 Content-Transfer-Encoding: 8bit From: Aleksandr Burakov [ Upstream commit bc87bb342f106a0402186bcb588fcbe945dced4b ] There are some actions with value 'tmp' but 'dst_addr' is checked instead. It is obvious that a copy-paste error was made here and the value of variable 'tmp' should be checked here. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Aleksandr Burakov Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/via/accel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/via/accel.c b/drivers/video/fbdev/via/accel.c index 0a1bc7a4d7853..1e04026f08091 100644 --- a/drivers/video/fbdev/via/accel.c +++ b/drivers/video/fbdev/via/accel.c @@ -115,7 +115,7 @@ static int hw_bitblt_1(void __iomem *engine, u8 op, u32 width, u32 height, if (op != VIA_BITBLT_FILL) { tmp = src_mem ? 0 : src_addr; - if (dst_addr & 0xE0000007) { + if (tmp & 0xE0000007) { printk(KERN_WARNING "hw_bitblt_1: Unsupported source " "address %X\n", tmp); return -EINVAL; @@ -260,7 +260,7 @@ static int hw_bitblt_2(void __iomem *engine, u8 op, u32 width, u32 height, writel(tmp, engine + 0x18); tmp = src_mem ? 0 : src_addr; - if (dst_addr & 0xE0000007) { + if (tmp & 0xE0000007) { printk(KERN_WARNING "hw_bitblt_2: Unsupported source " "address %X\n", tmp); return -EINVAL; -- 2.43.0