From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
laurent.pinchart@ideasonboard.com, dan.scally@ideasonboard.com,
linux-usb@vger.kernel.org
Subject: [PATCH AUTOSEL 6.1 04/15] usb: gadget: uvc: mark incomplete frames with UVC_STREAM_ERR
Date: Wed, 3 Apr 2024 13:18:48 -0400 [thread overview]
Message-ID: <20240403171909.345570-4-sashal@kernel.org> (raw)
In-Reply-To: <20240403171909.345570-1-sashal@kernel.org>
From: Michael Grzeschik <m.grzeschik@pengutronix.de>
[ Upstream commit 2a3b7af120477d0571b815ccb8600cafd5ebf02f ]
If an frame was transmitted incomplete to the host, we set the
UVC_STREAM_ERR bit in the header for the last request that is going
to be queued. This way the host will know that it should drop the
frame instead of trying to display the corrupted content.
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
Link: https://lore.kernel.org/r/20240214-uvc-error-tag-v1-2-37659a3877fe@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/usb/gadget/function/uvc_video.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index e81865978299c..be48d5ab17c7b 100644
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -35,6 +35,9 @@ uvc_video_encode_header(struct uvc_video *video, struct uvc_buffer *buf,
data[1] = UVC_STREAM_EOH | video->fid;
+ if (video->queue.flags & UVC_QUEUE_DROP_INCOMPLETE)
+ data[1] |= UVC_STREAM_ERR;
+
if (video->queue.buf_used == 0 && ts.tv_sec) {
/* dwClockFrequency is 48 MHz */
u32 pts = ((u64)ts.tv_sec * USEC_PER_SEC + ts.tv_nsec / NSEC_PER_USEC) * 48;
--
2.43.0
next prev parent reply other threads:[~2024-04-03 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 17:18 [PATCH AUTOSEL 6.1 01/15] tools: iio: replace seekdir() in iio_generic_buffer Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 02/15] usb: storage: sddr55: fix sloppy typing in sddr55_{read|write}_data() Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 03/15] bus: mhi: host: Add MHI_PM_SYS_ERR_FAIL state Sasha Levin
2024-04-03 17:18 ` Sasha Levin [this message]
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 05/15] usb: typec: ucsi: Limit read size on v1.2 Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 06/15] thunderbolt: Keep the domain powered when USB4 port is in redrive mode Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 07/15] usb: typec: tcpci: add generic tcpci fallback compatible Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 08/15] usb: sl811-hcd: only defined function checkdone if QUIRK2 is defined Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 09/15] thermal/of: Assume polling-delay(-passive) 0 when absent Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 10/15] ASoC: soc-core.c: Skip dummy codec when adding platforms Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 11/15] x86/xen: attempt to inflate the memory balloon on PVH Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 12/15] fbdev: viafb: fix typo in hw_bitblt_1 and hw_bitblt_2 Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 13/15] io_uring: clear opcode specific data for an early failure Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 14/15] drivers/nvme: Add quirks for device 126f:2262 Sasha Levin
2024-04-03 17:18 ` [PATCH AUTOSEL 6.1 15/15] fbmon: prevent division by zero in fb_videomode_from_videomode() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403171909.345570-4-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox