[PATCH] netfs, cachefiles: include linux/bio.h for BIO_MAX_VECS

[PATCH] netfs, cachefiles: include linux/bio.h for BIO_MAX_VECS

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

The newly added code causes a build failure without this in some configurations:

fs/cachefiles/io.c: In function 'cachefiles_prepare_write_subreq':
fs/cachefiles/io.c:633:31: error: 'BIO_MAX_VECS' undeclared (first use in this function); did you mean 'BIO_MAX_SECTORS'?
  633 |         subreq->max_nr_segs = BIO_MAX_VECS;
      |                               ^~~~~~~~~~~~
      |                               BIO_MAX_SECTORS
fs/cachefiles/io.c:633:31: note: each undeclared identifier is reported only once for each function it appears in

Fixes: 0d393b1a6699 ("netfs, cachefiles: Implement helpers for new write code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/cachefiles/io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/cachefiles/io.c b/fs/cachefiles/io.c
index 437b24b0fd1c..cc5505d4ddaa 100644
--- a/fs/cachefiles/io.c
+++ b/fs/cachefiles/io.c
@@ -5,6 +5,7 @@
  * Written by David Howells (dhowells@redhat.com)
  */
 
+#include <linux/bio.h>
 #include <linux/mount.h>
 #include <linux/slab.h>
 #include <linux/file.h>
-- 
2.39.2

Re: [PATCH] netfs, cachefiles: include linux/bio.h for BIO_MAX_VECS

[Christian Brauner]

On Thu, 04 Apr 2024 14:34:06 +0200, Arnd Bergmann wrote:
> The newly added code causes a build failure without this in some configurations:
> 
> fs/cachefiles/io.c: In function 'cachefiles_prepare_write_subreq':
> fs/cachefiles/io.c:633:31: error: 'BIO_MAX_VECS' undeclared (first use in this function); did you mean 'BIO_MAX_SECTORS'?
>   633 |         subreq->max_nr_segs = BIO_MAX_VECS;
>       |                               ^~~~~~~~~~~~
>       |                               BIO_MAX_SECTORS
> fs/cachefiles/io.c:633:31: note: each undeclared identifier is reported only once for each function it appears in
> 
> [...]

Applied to the vfs.netfs branch of the vfs/vfs.git tree.
Patches in the vfs.netfs branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.netfs

[1/1] netfs, cachefiles: include linux/bio.h for BIO_MAX_VECS
      https://git.kernel.org/vfs/vfs/c/d1e3ad45a29e