From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
lukas@wunner.de, bbhushan2@marvell.com, jarkko@kernel.org,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v8 09/13] crypto: ecdsa - Replace ndigits with nbits where precision is needed
Date: Thu, 4 Apr 2024 10:18:52 -0400 [thread overview]
Message-ID: <20240404141856.2399142-10-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240404141856.2399142-1-stefanb@linux.ibm.com>
Replace the usage of ndigits with nbits where precise space calculations
are needed, such as in ecdsa_max_size where the length of a coordinate is
determined.
Tested-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
crypto/ecdsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/ecdsa.c b/crypto/ecdsa.c
index 9b84ab503276..75d3eea885db 100644
--- a/crypto/ecdsa.c
+++ b/crypto/ecdsa.c
@@ -266,7 +266,7 @@ static unsigned int ecdsa_max_size(struct crypto_akcipher *tfm)
{
struct ecc_ctx *ctx = akcipher_tfm_ctx(tfm);
- return ctx->pub_key.ndigits << ECC_DIGITS_TO_BYTES_SHIFT;
+ return DIV_ROUND_UP(ctx->curve->nbits, 8);
}
static int ecdsa_nist_p384_init_tfm(struct crypto_akcipher *tfm)
--
2.43.0
next prev parent reply other threads:[~2024-04-04 14:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 14:18 [PATCH v8 00/13] Add support for NIST P521 to ecdsa Stefan Berger
2024-04-04 14:18 ` [PATCH v8 01/13] crypto: ecc - Use ECC_CURVE_NIST_P192/256/384_DIGITS where possible Stefan Berger
2024-04-04 14:18 ` [PATCH v8 02/13] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-04-04 14:18 ` [PATCH v8 03/13] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-04-04 14:18 ` [PATCH v8 04/13] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-04-04 14:18 ` [PATCH v8 05/13] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-04-04 14:40 ` Vitaly Chikunov
2024-04-04 14:18 ` [PATCH v8 06/13] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521 Stefan Berger
2024-04-04 14:18 ` [PATCH v8 07/13] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-04-04 14:18 ` [PATCH v8 08/13] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-04-04 14:18 ` Stefan Berger [this message]
2024-04-04 14:18 ` [PATCH v8 10/13] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-04-04 14:18 ` [PATCH v8 11/13] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-04-04 14:18 ` [PATCH v8 12/13] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-04-04 14:18 ` [PATCH v8 13/13] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
2024-04-04 16:33 ` [PATCH v8 00/13] Add support for NIST P521 to ecdsa Lukas Wunner
2024-04-12 7:31 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404141856.2399142-10-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox