From: Stefan Berger <stefanb@linux.ibm.com>
To: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br,
lukas@wunner.de, bbhushan2@marvell.com, jarkko@kernel.org,
Stefan Berger <stefanb@linux.ibm.com>
Subject: [PATCH v8 06/13] crypto: ecc - Implement vli_mmod_fast_521 for NIST p521
Date: Thu, 4 Apr 2024 10:18:49 -0400 [thread overview]
Message-ID: <20240404141856.2399142-7-stefanb@linux.ibm.com> (raw)
In-Reply-To: <20240404141856.2399142-1-stefanb@linux.ibm.com>
Implement vli_mmod_fast_521 following the description for how to calculate
the modulus for NIST P521 in the NIST publication "Recommendations for
Discrete Logarithm-Based Cryptography: Elliptic Curve Domain Parameters"
section G.1.4.
NIST p521 requires 9 64bit digits, so increase the ECC_MAX_DIGITS so that
the vli digit array provides enough elements to fit the larger integers
required by this curve.
Tested-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
crypto/ecc.c | 25 +++++++++++++++++++++++++
include/crypto/internal/ecc.h | 3 ++-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/crypto/ecc.c b/crypto/ecc.c
index 01aa70e97e55..90a8c7ea9095 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -902,6 +902,28 @@ static void vli_mmod_fast_384(u64 *result, const u64 *product,
#undef AND64H
#undef AND64L
+/*
+ * Computes result = product % curve_prime
+ * from "Recommendations for Discrete Logarithm-Based Cryptography:
+ * Elliptic Curve Domain Parameters" section G.1.4
+ */
+static void vli_mmod_fast_521(u64 *result, const u64 *product,
+ const u64 *curve_prime, u64 *tmp)
+{
+ const unsigned int ndigits = ECC_CURVE_NIST_P521_DIGITS;
+ size_t i;
+
+ /* Initialize result with lowest 521 bits from product */
+ vli_set(result, product, ndigits);
+ result[8] &= 0x1ff;
+
+ for (i = 0; i < ndigits; i++)
+ tmp[i] = (product[8 + i] >> 9) | (product[9 + i] << 55);
+ tmp[8] &= 0x1ff;
+
+ vli_mod_add(result, result, tmp, curve_prime, ndigits);
+}
+
/* Computes result = product % curve_prime for different curve_primes.
*
* Note that curve_primes are distinguished just by heuristic check and
@@ -941,6 +963,9 @@ static bool vli_mmod_fast(u64 *result, u64 *product,
case ECC_CURVE_NIST_P384_DIGITS:
vli_mmod_fast_384(result, product, curve_prime, tmp);
break;
+ case ECC_CURVE_NIST_P521_DIGITS:
+ vli_mmod_fast_521(result, product, curve_prime, tmp);
+ break;
default:
pr_err_ratelimited("ecc: unsupported digits size!\n");
return false;
diff --git a/include/crypto/internal/ecc.h b/include/crypto/internal/ecc.h
index ab722a8986b7..4e2f5f938e91 100644
--- a/include/crypto/internal/ecc.h
+++ b/include/crypto/internal/ecc.h
@@ -33,7 +33,8 @@
#define ECC_CURVE_NIST_P192_DIGITS 3
#define ECC_CURVE_NIST_P256_DIGITS 4
#define ECC_CURVE_NIST_P384_DIGITS 6
-#define ECC_MAX_DIGITS (512 / 64) /* due to ecrdsa */
+#define ECC_CURVE_NIST_P521_DIGITS 9
+#define ECC_MAX_DIGITS DIV_ROUND_UP(521, 64) /* NIST P521 */
#define ECC_DIGITS_TO_BYTES_SHIFT 3
--
2.43.0
next prev parent reply other threads:[~2024-04-04 14:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 14:18 [PATCH v8 00/13] Add support for NIST P521 to ecdsa Stefan Berger
2024-04-04 14:18 ` [PATCH v8 01/13] crypto: ecc - Use ECC_CURVE_NIST_P192/256/384_DIGITS where possible Stefan Berger
2024-04-04 14:18 ` [PATCH v8 02/13] crypto: ecdsa - Convert byte arrays with key coordinates to digits Stefan Berger
2024-04-04 14:18 ` [PATCH v8 03/13] crypto: ecdsa - Adjust tests on length of key parameters Stefan Berger
2024-04-04 14:18 ` [PATCH v8 04/13] crypto: ecdsa - Extend res.x mod n calculation for NIST P521 Stefan Berger
2024-04-04 14:18 ` [PATCH v8 05/13] crypto: ecc - Add nbits field to ecc_curve structure Stefan Berger
2024-04-04 14:40 ` Vitaly Chikunov
2024-04-04 14:18 ` Stefan Berger [this message]
2024-04-04 14:18 ` [PATCH v8 07/13] crypto: ecc - Add special case for NIST P521 in ecc_point_mult Stefan Berger
2024-04-04 14:18 ` [PATCH v8 08/13] crypto: ecc - Add NIST P521 curve parameters Stefan Berger
2024-04-04 14:18 ` [PATCH v8 09/13] crypto: ecdsa - Replace ndigits with nbits where precision is needed Stefan Berger
2024-04-04 14:18 ` [PATCH v8 10/13] crypto: ecdsa - Rename keylen to bufsize where necessary Stefan Berger
2024-04-04 14:18 ` [PATCH v8 11/13] crypto: ecdsa - Register NIST P521 and extend test suite Stefan Berger
2024-04-04 14:18 ` [PATCH v8 12/13] crypto: asymmetric_keys - Adjust signature size calculation for NIST P521 Stefan Berger
2024-04-04 14:18 ` [PATCH v8 13/13] crypto: x509 - Add OID for NIST P521 and extend parser for it Stefan Berger
2024-04-04 16:33 ` [PATCH v8 00/13] Add support for NIST P521 to ecdsa Lukas Wunner
2024-04-12 7:31 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404141856.2399142-7-stefanb@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=saulo.alessandre@tse.jus.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox