From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D9E10962; Thu, 4 Apr 2024 17:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712252343; cv=none; b=snZnLhFsWHEV2nCJk2wr1VMpqaHpV+rsc7EjzDeSjpS6E+brlAXkxKjZVHdmFNEwofTgHLgUx2J6msDMZ4rt7DSSc0j82RNXofjlwGb1CBQgiz3LAIC6jahuhSHlm+LbMaRtgcuxeXW36oBsxBLgM7N8AQpdF0eAqIkdtw1751Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712252343; c=relaxed/simple; bh=WWRwiKZ7ojw9erMXt2B4DeqPhUMuv4qbTOVKdIj34nM=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tG8icT1XFiRB5usDnkVfTwYGPsX+ZuGvfbMchyHyP5cNdlm5MiahiF3qUuv8GeUMjSxk2y4RNXuG7QN12RQbMHf2pbz/lNWpTfAAkcfLygcJ5M2R8WPXisV390NoPyNSWoh5oYeaJZT8cMHxHss1W62mU6OZVTg79+vBV2d6QQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4V9TJB5WVFz6K7G7; Fri, 5 Apr 2024 01:34:18 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 40413140A36; Fri, 5 Apr 2024 01:38:58 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 4 Apr 2024 18:38:57 +0100 Date: Thu, 4 Apr 2024 18:38:57 +0100 From: Jonathan Cameron To: CC: Dave Jiang , Fan Ni , "Navneet Singh" , Dan Williams , Davidlohr Bueso , Alison Schofield , Vishal Verma , , , Subject: Re: [PATCH 23/26] cxl/mem: Trace Dynamic capacity Event Record Message-ID: <20240404183857.00007ce4@Huawei.com> In-Reply-To: <20240324-dcd-type2-upstream-v1-23-b7b00d623625@intel.com> References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com> <20240324-dcd-type2-upstream-v1-23-b7b00d623625@intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) On Sun, 24 Mar 2024 16:18:26 -0700 ira.weiny@intel.com wrote: > From: Navneet Singh > > CXL rev 3.1 section 8.2.9.2.1 adds the Dynamic Capacity Event Records. > Notify the host of extents being added or removed. User space has > little use for these events other than for debugging. > > Add DC trace points to the trace log for debugging purposes. > > Signed-off-by: Navneet Singh > Signed-off-by: Ira Weiny > One trivial thing Reviewed-by: Jonathan Cameron > +/* > + * DYNAMIC CAPACITY Event Record - DER > + * > + * CXL rev 3.0 section 8.2.9.2.1.5 Table 8-47 > + */ > + > +#define CXL_DC_ADD_CAPACITY 0x00 > +#define CXL_DC_REL_CAPACITY 0x01 > +#define CXL_DC_FORCED_REL_CAPACITY 0x02 > +#define CXL_DC_REG_CONF_UPDATED 0x03 > +#define show_dc_evt_type(type) __print_symbolic(type, \ > + { CXL_DC_ADD_CAPACITY, "Add capacity"}, \ > + { CXL_DC_REL_CAPACITY, "Release capacity"}, \ > + { CXL_DC_FORCED_REL_CAPACITY, "Forced capacity release"}, \ > + { CXL_DC_REG_CONF_UPDATED, "Region Configuration Updated" } \ Tidy up indents and alignment etc. Doesn't look consistent.