From: Sean Christopherson <seanjc@google.com>
To: stable@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Matlack <dmatlack@google.com>,
Pasha Tatashin <tatashin@google.com>,
Michael Krebs <mkrebs@google.com>,
Jim Mattson <jmattson@google.com>
Subject: [PATCH 5.15 1/2] KVM: x86: Bail to userspace if emulation of atomic user access faults
Date: Thu, 4 Apr 2024 16:40:03 -0700 [thread overview]
Message-ID: <20240404234004.911293-2-seanjc@google.com> (raw)
In-Reply-To: <20240404234004.911293-1-seanjc@google.com>
Upstream commit 5d6c7de6446e9ab3fb41d6f7d82770e50998f3de.
Exit to userspace when emulating an atomic guest access if the CMPXCHG on
the userspace address faults. Emulating the access as a write and thus
likely treating it as emulated MMIO is wrong, as KVM has already
confirmed there is a valid, writable memslot.
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20220202004945.2540433-6-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index aa6f700f8c5f..a9c26397dcfd 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -7105,7 +7105,7 @@ static int emulator_cmpxchg_emulated(struct x86_emulate_ctxt *ctxt,
}
if (r < 0)
- goto emul_write;
+ return X86EMUL_UNHANDLEABLE;
if (r)
return X86EMUL_CMPXCHG_FAILED;
--
2.44.0.478.gd926399ef9-goog
next prev parent reply other threads:[~2024-04-04 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 23:40 [PATCH 5.15 0/2] KVM: x86: Fix for dirty logging emulated atomics Sean Christopherson
2024-04-04 23:40 ` Sean Christopherson [this message]
2024-04-04 23:40 ` [PATCH 5.15 2/2] KVM: x86: Mark target gfn of emulated atomic instruction as dirty Sean Christopherson
2024-04-05 9:35 ` [PATCH 5.15 0/2] KVM: x86: Fix for dirty logging emulated atomics Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404234004.911293-2-seanjc@google.com \
--to=seanjc@google.com \
--cc=dmatlack@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrebs@google.com \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox