Re: [PATCH 1/1] serial: 8250_of: Add clock_notifier

Greg Kroah-Hartman
2024-04-04T07:50:17Z

On Thu, Apr 04, 2024 at 09:44:50AM +0200, Bastien Curutchet wrote:
> The UART's input clock rate can change at runtime but this is not
> handled by the driver.
>
> Add a clock_notifier callback that updates the divisors when the input
> clock is updated. The serial8250_update_uartclk() is used to do so.
> PRE_RATE_CHANGE and ABORT_RATE_CHANGE notifications are ignored, only
> the POST_RATE_CHANGE is used.

Why just this one notification? You say they are ignored but do not say
why.

>
> Reorder the #include to match alphabetic order.

That is not needed here, why do that now? And "alphabetic order" is not
an issue for tty drivers, no need to do that, but if you really want to,
a separate patch series is good for that.

thanks,

greg k-h