Re: [PATCH 1/1] serial: 8250_of: Add clock_notifier

Herve Codina
2024-04-04T08:34:49Z

Hi Bastien,

On Thu, 4 Apr 2024 09:44:50 +0200
Bastien Curutchet <bastien.curutchet@bootlin.com> wrote:

> The UART's input clock rate can change at runtime but this is not
> handled by the driver.
>
> Add a clock_notifier callback that updates the divisors when the input
> clock is updated. The serial8250_update_uartclk() is used to do so.
> PRE_RATE_CHANGE and ABORT_RATE_CHANGE notifications are ignored, only
> the POST_RATE_CHANGE is used.
>
> Reorder the #include to match alphabetic order.
>
> It has been tested on a DAVINCI/OMAP-L138 processor.
>
> Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
...
> +static int of_platform_serial_clk_notifier_cb(struct notifier_block *nb, unsigned long event,
> + void *data)
> +{
> + struct of_serial_info *info = clk_nb_to_info(nb);
> + struct uart_8250_port *port8250 = serial8250_get_port(info->line);
> + struct clk_notifier_data *ndata = data;
> +
> + if (IS_ERR(info->clk))
> + return NOTIFY_DONE;

The info->clk pointer cannot contain an error code.
Can you double check that and remove the test if it is not needed?

Best regards,
Hervé