Re: [PATCH v19 2/9] usb: dwc3: core: Access XHCI address space temporarily to read port info

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Apr 04, 2024 at 10:07:27AM +0200, Krzysztof Kozlowski wrote:
> On 04/04/2024 09:21, Johan Hovold wrote:
> > On Thu, Apr 04, 2024 at 10:42:22AM +0530, Krishna Kurapati wrote:
> >  
> >> +static int dwc3_get_num_ports(struct dwc3 *dwc)
> >> +{
> >> +	void __iomem *base;
> >> +	u8 major_revision;
> >> +	u32 offset;
> >> +	u32 val;
> >> +
> >> +	/*
> >> +	 * Remap xHCI address space to access XHCI ext cap regs since it is
> >> +	 * needed to get information on number of ports present.
> >> +	 */
> >> +	base = ioremap(dwc->xhci_resources[0].start,
> >> +		       resource_size(&dwc->xhci_resources[0]));
> >> +	if (!base)
> >> +		return PTR_ERR(base);
> > 
> > This is obviously still broken. You need to update the return value as
> > well.
> > 
> > Fix in v20.
> 
> If one patchset reaches 20 versions, I think it is time to stop and
> really think from the beginning, why issues keep appearing and reviewers
> are still not happy.
> 
> Maybe you did not perform extensive internal review, which you are
> encouraged to by your own internal policies, AFAIR. Before posting next
> version, please really get some internal review first.

Also get those internal reviewers to sign-off on the commits and have
that show up when you post them next.  That way they are also
responsible for this patchset, it's not fair that they are making you do
all the work here :)

thanks,

greg k-h