From: "David E. Box" <david.e.box@linux.intel.com>
To: david.e.box@linux.intel.com, hdegoede@redhat.com,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
sathyanarayanan.kuppuswamy@linux.intel.com
Subject: [PATCH V3 1/9] platform/x86/intel/sdsi: Set message size during writes
Date: Thu, 4 Apr 2024 20:24:59 -0700 [thread overview]
Message-ID: <20240405032507.2637311-2-david.e.box@linux.intel.com> (raw)
In-Reply-To: <20240405032507.2637311-1-david.e.box@linux.intel.com>
New mailbox commands will support sending multi packet writes and updated
firmware now requires that the message size be written for all commands
along with the packet size. Since the driver doesn't perform writes larger
than the packet size, set the message size to the same value.
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
V3 - no changes
V2 - no changes
drivers/platform/x86/intel/sdsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
index 556e7c6dbb05..a70c071de6e2 100644
--- a/drivers/platform/x86/intel/sdsi.c
+++ b/drivers/platform/x86/intel/sdsi.c
@@ -252,6 +252,7 @@ static int sdsi_mbox_cmd_write(struct sdsi_priv *priv, struct sdsi_mbox_info *in
FIELD_PREP(CTRL_SOM, 1) |
FIELD_PREP(CTRL_RUN_BUSY, 1) |
FIELD_PREP(CTRL_READ_WRITE, 1) |
+ FIELD_PREP(CTRL_MSG_SIZE, info->size) |
FIELD_PREP(CTRL_PACKET_SIZE, info->size);
writeq(control, priv->control_addr);
--
2.34.1
next prev parent reply other threads:[~2024-04-05 3:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 3:24 [PATCH V3 0/9] Intel On Demand changes David E. Box
2024-04-05 3:24 ` David E. Box [this message]
2024-04-05 14:29 ` [PATCH V3 1/9] platform/x86/intel/sdsi: Set message size during writes Kuppuswamy Sathyanarayanan
2024-04-05 3:25 ` [PATCH V3 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows David E. Box
2024-04-05 3:25 ` [PATCH V3 3/9] platform/x86/intel/sdsi: Add in-band BIOS lock support David E. Box
2024-04-05 3:25 ` [PATCH V3 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state David E. Box
2024-04-05 3:25 ` [PATCH V3 5/9] tools/arch/x86/intel_sdsi: Fix maximum meter bundle length David E. Box
2024-04-08 16:59 ` Ilpo Järvinen
2024-04-05 3:25 ` [PATCH V3 6/9] tools/arch/x86/intel_sdsi: Fix meter_show display David E. Box
2024-04-05 14:29 ` Kuppuswamy Sathyanarayanan
2024-04-08 17:13 ` Ilpo Järvinen
2024-04-05 3:25 ` [PATCH V3 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding David E. Box
2024-04-08 17:10 ` Ilpo Järvinen
2024-04-05 3:25 ` [PATCH V3 8/9] platform/x86/intel/sdsi: Simplify ascii printing David E. Box
2024-04-08 17:22 ` Ilpo Järvinen
2024-04-08 22:11 ` David E. Box
2024-04-05 3:25 ` [PATCH V3 9/9] tools: intel_sdsi: Add current meter support David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405032507.2637311-2-david.e.box@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox