public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David E. Box" <david.e.box@linux.intel.com>
To: david.e.box@linux.intel.com, hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	sathyanarayanan.kuppuswamy@linux.intel.com
Subject: [PATCH V3 3/9] platform/x86/intel/sdsi: Add in-band BIOS lock support
Date: Thu,  4 Apr 2024 20:25:01 -0700	[thread overview]
Message-ID: <20240405032507.2637311-4-david.e.box@linux.intel.com> (raw)
In-Reply-To: <20240405032507.2637311-1-david.e.box@linux.intel.com>

From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

As per SDSi in-band interface specification, sec titled "BIOS lock for
in-band provisioning", when IB_LOCK bit is set in control qword, the
SDSI agent is only allowed to perform the read flow, but not allowed to
provision license blob or license key. So add check for it in
sdsi_provision().

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---

V3 - no changes

V2 - Move sdsi_ib_locked() check after overflow check

 drivers/platform/x86/intel/sdsi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel/sdsi.c
index d80c2dc0ce71..bb3eaf5eb382 100644
--- a/drivers/platform/x86/intel/sdsi.c
+++ b/drivers/platform/x86/intel/sdsi.c
@@ -67,6 +67,7 @@
 #define CTRL_OWNER			GENMASK(5, 4)
 #define CTRL_COMPLETE			BIT(6)
 #define CTRL_READY			BIT(7)
+#define CTRL_INBAND_LOCK		BIT(32)
 #define CTRL_STATUS			GENMASK(15, 8)
 #define CTRL_PACKET_SIZE		GENMASK(31, 16)
 #define CTRL_MSG_SIZE			GENMASK(63, 48)
@@ -346,6 +347,11 @@ static int sdsi_mbox_read(struct sdsi_priv *priv, struct sdsi_mbox_info *info, s
 	return sdsi_mbox_cmd_read(priv, info, data_size);
 }
 
+static bool sdsi_ib_locked(struct sdsi_priv *priv)
+{
+	return !!FIELD_GET(CTRL_INBAND_LOCK, readq(priv->control_addr));
+}
+
 static ssize_t sdsi_provision(struct sdsi_priv *priv, char *buf, size_t count,
 			      enum sdsi_command command)
 {
@@ -355,6 +361,10 @@ static ssize_t sdsi_provision(struct sdsi_priv *priv, char *buf, size_t count,
 	if (count > (SDSI_SIZE_WRITE_MSG - SDSI_SIZE_CMD))
 		return -EOVERFLOW;
 
+	/* Make sure In-band lock is not set */
+	if (sdsi_ib_locked(priv))
+		return -EPERM;
+
 	/* Qword aligned message + command qword */
 	info.size = round_up(count, SDSI_SIZE_CMD) + SDSI_SIZE_CMD;
 
-- 
2.34.1


  parent reply	other threads:[~2024-04-05  3:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05  3:24 [PATCH V3 0/9] Intel On Demand changes David E. Box
2024-04-05  3:24 ` [PATCH V3 1/9] platform/x86/intel/sdsi: Set message size during writes David E. Box
2024-04-05 14:29   ` Kuppuswamy Sathyanarayanan
2024-04-05  3:25 ` [PATCH V3 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows David E. Box
2024-04-05  3:25 ` David E. Box [this message]
2024-04-05  3:25 ` [PATCH V3 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state David E. Box
2024-04-05  3:25 ` [PATCH V3 5/9] tools/arch/x86/intel_sdsi: Fix maximum meter bundle length David E. Box
2024-04-08 16:59   ` Ilpo Järvinen
2024-04-05  3:25 ` [PATCH V3 6/9] tools/arch/x86/intel_sdsi: Fix meter_show display David E. Box
2024-04-05 14:29   ` Kuppuswamy Sathyanarayanan
2024-04-08 17:13   ` Ilpo Järvinen
2024-04-05  3:25 ` [PATCH V3 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding David E. Box
2024-04-08 17:10   ` Ilpo Järvinen
2024-04-05  3:25 ` [PATCH V3 8/9] platform/x86/intel/sdsi: Simplify ascii printing David E. Box
2024-04-08 17:22   ` Ilpo Järvinen
2024-04-08 22:11     ` David E. Box
2024-04-05  3:25 ` [PATCH V3 9/9] tools: intel_sdsi: Add current meter support David E. Box

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405032507.2637311-4-david.e.box@linux.intel.com \
    --to=david.e.box@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox