public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David E. Box" <david.e.box@linux.intel.com>
To: david.e.box@linux.intel.com, hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	sathyanarayanan.kuppuswamy@linux.intel.com
Subject: [PATCH V3 8/9] platform/x86/intel/sdsi: Simplify ascii printing
Date: Thu,  4 Apr 2024 20:25:06 -0700	[thread overview]
Message-ID: <20240405032507.2637311-9-david.e.box@linux.intel.com> (raw)
In-Reply-To: <20240405032507.2637311-1-david.e.box@linux.intel.com>

Use printf width specifier to set the display length of encoded feature
names.

Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---

V3 - Add FEAT_LEN #def

V2 - Split of V1 patch 7

 tools/arch/x86/intel_sdsi/intel_sdsi.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/tools/arch/x86/intel_sdsi/intel_sdsi.c b/tools/arch/x86/intel_sdsi/intel_sdsi.c
index 45bc69e6718e..0c9670ba1f15 100644
--- a/tools/arch/x86/intel_sdsi/intel_sdsi.c
+++ b/tools/arch/x86/intel_sdsi/intel_sdsi.c
@@ -43,6 +43,7 @@
 #define METER_CERT_MAX_SIZE	4096
 #define STATE_MAX_NUM_LICENSES	16
 #define STATE_MAX_NUM_IN_BUNDLE	(uint32_t)8
+#define FEAT_LEN		4
 
 #define __round_mask(x, y) ((__typeof__(x))((y) - 1))
 #define round_up(x, y) ((((x) - 1) | __round_mask(x, y)) + 1)
@@ -409,11 +410,10 @@ static int sdsi_meter_cert_show(struct sdsi_dev *s)
 
 	printf("Number of Feature Counters:   %ld\n", BUNDLE_COUNT(mc->bundle_length));
 	while (count < BUNDLE_COUNT(mc->bundle_length)) {
-		char feature[5];
+		char feature[FEAT_LEN];
 
-		feature[4] = '\0';
 		get_feature(bec[count].encoding, feature);
-		printf("    %s:          %d\n", feature, bec[count].counter);
+		printf("    %.4s:          %d\n", feature, bec[count].counter);
 		++count;
 	}
 
@@ -494,7 +494,7 @@ static int sdsi_state_cert_show(struct sdsi_dev *s)
 			sizeof(*lki) +			// size of the license key info
 			offset;				// offset to this blob content
 		struct bundle_encoding *bundle = (void *)(lbc) + sizeof(*lbc);
-		char feature[5];
+		char feature[FEAT_LEN];
 		uint32_t i;
 
 		printf("     Blob %d:\n", count - 1);
@@ -507,11 +507,9 @@ static int sdsi_state_cert_show(struct sdsi_dev *s)
 		printf("        Blob revision ID:           %u\n", lbc->rev_id);
 		printf("        Number of Features:         %u\n", lbc->num_bundles);
 
-		feature[4] = '\0';
-
 		for (i = 0; i < min(lbc->num_bundles, STATE_MAX_NUM_IN_BUNDLE); i++) {
 			get_feature(bundle[i].encoding, feature);
-			printf("                 Feature %d:         %s\n", i, feature);
+			printf("                 Feature %d:         %.4s\n", i, feature);
 		}
 
 		if (lbc->num_bundles > STATE_MAX_NUM_IN_BUNDLE)
-- 
2.34.1


  parent reply	other threads:[~2024-04-05  3:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-05  3:24 [PATCH V3 0/9] Intel On Demand changes David E. Box
2024-04-05  3:24 ` [PATCH V3 1/9] platform/x86/intel/sdsi: Set message size during writes David E. Box
2024-04-05 14:29   ` Kuppuswamy Sathyanarayanan
2024-04-05  3:25 ` [PATCH V3 2/9] platform/x86/intel/sdsi: Combine read and write mailbox flows David E. Box
2024-04-05  3:25 ` [PATCH V3 3/9] platform/x86/intel/sdsi: Add in-band BIOS lock support David E. Box
2024-04-05  3:25 ` [PATCH V3 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state David E. Box
2024-04-05  3:25 ` [PATCH V3 5/9] tools/arch/x86/intel_sdsi: Fix maximum meter bundle length David E. Box
2024-04-08 16:59   ` Ilpo Järvinen
2024-04-05  3:25 ` [PATCH V3 6/9] tools/arch/x86/intel_sdsi: Fix meter_show display David E. Box
2024-04-05 14:29   ` Kuppuswamy Sathyanarayanan
2024-04-08 17:13   ` Ilpo Järvinen
2024-04-05  3:25 ` [PATCH V3 7/9] tools/arch/x86/intel_sdsi: Fix meter_certificate decoding David E. Box
2024-04-08 17:10   ` Ilpo Järvinen
2024-04-05  3:25 ` David E. Box [this message]
2024-04-08 17:22   ` [PATCH V3 8/9] platform/x86/intel/sdsi: Simplify ascii printing Ilpo Järvinen
2024-04-08 22:11     ` David E. Box
2024-04-05  3:25 ` [PATCH V3 9/9] tools: intel_sdsi: Add current meter support David E. Box

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240405032507.2637311-9-david.e.box@linux.intel.com \
    --to=david.e.box@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox