From: Tony Lindgren <tony@atomide.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Yicong Yang <yangyicong@hisilicon.com>,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it
Date: Fri, 5 Apr 2024 08:42:23 +0300 [thread overview]
Message-ID: <20240405054223.GP5132@atomide.com> (raw)
In-Reply-To: <f0f200b0-34dc-430b-b55e-b133faf4db44@kernel.org>
* Jiri Slaby <jirislaby@kernel.org> [240405 05:25]:
> But again, serial8250_start_tx() should not be called after shutdown().
Sounds like we should add some check in addition to UPF_DEAD to
serial_port_runtime_suspend() and serial_port_runtime_resume() to
bail out early on shutdown.
Regards,
Tony
next prev parent reply other threads:[~2024-04-05 5:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 14:59 [PATCH v1 1/1] serial: core: Clearing the circular buffer before NULLifying it Andy Shevchenko
2024-04-05 5:25 ` Jiri Slaby
2024-04-05 5:42 ` Tony Lindgren [this message]
2024-04-05 15:17 ` Andy Shevchenko
2024-04-05 22:37 ` Andy Shevchenko
2024-04-06 5:46 ` Tony Lindgren
2024-04-08 15:45 ` Andy Shevchenko
2024-04-07 9:49 ` Yicong Yang
2024-04-08 14:36 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405054223.GP5132@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox