From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A31B224CC;
	Fri,  5 Apr 2024 05:42:46 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.50.62.9
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1712295768; cv=none; b=DBKQTnI8x1cYQqVqGGfy8ejPDIFaPNtooGuvS6spqzBm1o5vPHS6RePwmn5Ebz2HQ5tThNIjnGvgeUqd2UWDFlnD5i1Lb8tW78SA5AQMM2eG/cgtcbd7UiGfK1BEEcGFqWm4LWye7VXuXi7HXuOO98n7OEOtgqkOWlcl4TZ2ay8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1712295768; c=relaxed/simple;
	bh=AcltF4rXp8Wbpda+aejkh/mnoyPg7d26vErpj50Kt/s=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=WvMhOun9AMAtLWfmBRleivv/XZ8egeK4aA1RntEYNvuxBti8LDfct+zV/NZ7McGelpsgyc0oUekES3PhO28zAbfwGoST4ckZD+2rWwoeX9rEQnGW3C/LNYEpNqoNTHRompVOzDjjz4P/I9BZcnhfa3zHEU39ieP0BlXCwK9BT/A=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com; spf=fail smtp.mailfrom=atomide.com; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b=Cc76vaP6; arc=none smtp.client-ip=74.50.62.9
Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com
Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="Cc76vaP6"
Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216])
	by mail5.25mail.st (Postfix) with ESMTPSA id 995E860333;
	Fri,  5 Apr 2024 05:42:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com;
	s=25mailst; t=1712295759;
	bh=AcltF4rXp8Wbpda+aejkh/mnoyPg7d26vErpj50Kt/s=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=Cc76vaP6j3Q9EZW/45vE2uiMyUkrv75nWQEOIhm63C1ZFv56Ki2LAAqUkWQfEvvUB
	 hX4Tnw21pwCj1NW0AkKOVMMWLeE/t3q8PxmpnjaA7wwi+DqScIfrFIPyxzVu44Lwjj
	 KZo1kh3Ib+Tczklk+tFWHeXAEZQvt3gIXmnXYjT0avwHooJM80COE2fRKIEyBbNDM/
	 H+VnCZ5qfLMlMFsrAXobz8bwpd/Ad9FVBaGo3DaTkz06GQgusVuLRow1RDMmX85Zaq
	 dHbYd4spab87apKDOKy6Aea5O7laVqLahLGP/1VIuEAHIfCg8Lya7iuethjB5RrcGZ
	 c4DrDyXMBrSeA==
Date: Fri, 5 Apr 2024 08:42:23 +0300
From: Tony Lindgren <tony@atomide.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Yicong Yang <yangyicong@hisilicon.com>,
	kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v1 1/1] serial: core: Clearing the circular buffer before
 NULLifying it
Message-ID: <20240405054223.GP5132@atomide.com>
References: <20240404150034.41648-1-andriy.shevchenko@linux.intel.com>
 <f0f200b0-34dc-430b-b55e-b133faf4db44@kernel.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f0f200b0-34dc-430b-b55e-b133faf4db44@kernel.org>

* Jiri Slaby <jirislaby@kernel.org> [240405 05:25]:
> But again, serial8250_start_tx() should not be called after shutdown().

Sounds like we should add some check in addition to UPF_DEAD to
serial_port_runtime_suspend() and serial_port_runtime_resume() to
bail out early on shutdown.

Regards,

Tony