From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 1/2] x86/cpu: fix BSP detection when running as Xen PV guest
Date: Fri, 5 Apr 2024 14:34:33 +0200 [thread overview]
Message-ID: <20240405123434.24822-2-jgross@suse.com> (raw)
In-Reply-To: <20240405123434.24822-1-jgross@suse.com>
When booting as a Xen PV guest the boot processor isn't detected
correctly and the following message is shown:
CPU topo: Boot CPU APIC ID not the first enumerated APIC ID: 0 > 1
Additionally this results in one CPU being ignored.
Fix that by calling the BSP detection logic when registering the boot
CPU's APIC, too.
Fixes: 5c5682b9f87a ("x86/cpu: Detect real BSP on crash kernels")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/kernel/cpu/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/topology.c b/arch/x86/kernel/cpu/topology.c
index aaca8d235dc2..23c3db5e6396 100644
--- a/arch/x86/kernel/cpu/topology.c
+++ b/arch/x86/kernel/cpu/topology.c
@@ -255,7 +255,7 @@ void __init topology_register_boot_apic(u32 apic_id)
WARN_ON_ONCE(topo_info.boot_cpu_apic_id != BAD_APICID);
topo_info.boot_cpu_apic_id = apic_id;
- topo_register_apic(apic_id, CPU_ACPIID_INVALID, true);
+ topology_register_apic(apic_id, CPU_ACPIID_INVALID, true);
}
/**
--
2.35.3
next prev parent reply other threads:[~2024-04-05 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 12:34 [PATCH 0/2] x86: Two fixes related to Xen PV guest mode Juergen Gross
2024-04-05 12:34 ` Juergen Gross [this message]
2024-04-19 11:52 ` [PATCH 1/2] x86/cpu: fix BSP detection when running as Xen PV guest Juergen Gross
2024-04-30 11:55 ` Juergen Gross
2024-04-30 16:13 ` Thomas Gleixner
2024-05-02 12:32 ` Jürgen Groß
2024-05-02 14:39 ` [PATCH] x86/xen/smp_pv: Register the boot CPU APIC properly Thomas Gleixner
2024-05-02 14:42 ` Jürgen Groß
2024-04-05 12:34 ` [PATCH 2/2] x86/xen: return a sane initial apic id when running as PV guest Juergen Gross
2024-04-05 12:50 ` Andrew Cooper
2024-04-05 12:56 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240405123434.24822-2-jgross@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox