From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0786D3BBE8; Sun, 7 Apr 2024 13:12:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712495555; cv=none; b=c5kHMa8kBWVvOkbFpPjsd+zJfkW6ok05s4G50gSQE6i4LR+V3sAvxlDgaHiTVZNhGPz0H7Zi819d1db3ypte0bt72MRoKCyaim++syE69RUn8zFhd+A4e/9Q5Bn5G7UcPl7Dizlrb2oQrqJwg72B9i9adVnCmQnjN3e5qtDo5sI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712495555; c=relaxed/simple; bh=JjpRRG3PXe9lxL2lrfUPeO0PGBNzPIjjiZ54YmNqA+M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BYC5aqjN+EjYym7SLF7FYOKgAtsMvB3p3WSiZMcMYgUTDfMIW//pxa+RZmBQhUKm7NUF3RrPy46030R3OxXirn5cyi82b5RgFMynLy+ao6F7JkZBrAvRrQYURaMr+UtqSaZEestPMIv+lAFHIKV16mvqMqjctF93SW7j0HHwBns= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OvgOoSGX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OvgOoSGX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E3F53C43394; Sun, 7 Apr 2024 13:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712495554; bh=JjpRRG3PXe9lxL2lrfUPeO0PGBNzPIjjiZ54YmNqA+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OvgOoSGXmZ9x+pZluSopJa66r40lWf2TQ9bFYCRfGzAv8Mt690nXnmdp8pe9Cf6Q9 Q8j0bDSVd8hbN13qxfxnb2sZ42AFHl35tKMJymGXf1UMYISG5FqRXLvEyLFZml3w7u PO9ZMZWlLG3BG1B6u4GUaVNgkVR952KkmgYWV0Yc53eeT8ZNdAfuE3nf3uFyG4+rcc ZgSHRoQCl61AVejjJKSSmFXfpPZPPn5jMTAjf6BSBW7guZqH7RRVHpvfh8FzRz1v5R LiwXXz2cYms3Od/RGPhcxfceLYsAPSbjsG2gsWj0uqPrlI62ZfRpSM4ortxs2Ce14Z w7XLIsOtaNt+A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Justin Tee , "Martin K . Petersen" , Sasha Levin , james.smart@broadcom.com, dick.kennedy@broadcom.com, jejb@linux.ibm.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 6.6 02/22] scsi: lpfc: Move NPIV's transport unregistration to after resource clean up Date: Sun, 7 Apr 2024 09:12:01 -0400 Message-ID: <20240407131231.1051652-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240407131231.1051652-1-sashal@kernel.org> References: <20240407131231.1051652-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.6.25 Content-Transfer-Encoding: 8bit From: Justin Tee [ Upstream commit 4ddf01f2f1504fa08b766e8cfeec558e9f8eef6c ] There are cases after NPIV deletion where the fabric switch still believes the NPIV is logged into the fabric. This occurs when a vport is unregistered before the Remove All DA_ID CT and LOGO ELS are sent to the fabric. Currently fc_remove_host(), which calls dev_loss_tmo for all D_IDs including the fabric D_ID, removes the last ndlp reference and frees the ndlp rport object. This sometimes causes the race condition where the final DA_ID and LOGO are skipped from being sent to the fabric switch. Fix by moving the fc_remove_host() and scsi_remove_host() calls after DA_ID and LOGO are sent. Signed-off-by: Justin Tee Link: https://lore.kernel.org/r/20240305200503.57317-3-justintee8345@gmail.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/lpfc/lpfc_vport.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_vport.c b/drivers/scsi/lpfc/lpfc_vport.c index 6c7559cf1a4b6..9e0e9e02d2c47 100644 --- a/drivers/scsi/lpfc/lpfc_vport.c +++ b/drivers/scsi/lpfc/lpfc_vport.c @@ -683,10 +683,6 @@ lpfc_vport_delete(struct fc_vport *fc_vport) lpfc_free_sysfs_attr(vport); lpfc_debugfs_terminate(vport); - /* Remove FC host to break driver binding. */ - fc_remove_host(shost); - scsi_remove_host(shost); - /* Send the DA_ID and Fabric LOGO to cleanup Nameserver entries. */ ndlp = lpfc_findnode_did(vport, Fabric_DID); if (!ndlp) @@ -730,6 +726,10 @@ lpfc_vport_delete(struct fc_vport *fc_vport) skip_logo: + /* Remove FC host to break driver binding. */ + fc_remove_host(shost); + scsi_remove_host(shost); + lpfc_cleanup(vport); /* Remove scsi host now. The nodes are cleaned up. */ -- 2.43.0