* [PATCH] accel/qaic: mark debugfs stub functions as static inline
@ 2024-04-09 13:39 Arnd Bergmann
2024-04-12 15:52 ` Jeffrey Hugo
2024-04-12 15:56 ` Jeffrey Hugo
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-04-09 13:39 UTC (permalink / raw)
To: Jeffrey Hugo, Oded Gabbay, Jacek Lawrynowicz,
Pranjal Ramajor Asha Kanojiya, Carl Vanderlip
Cc: Arnd Bergmann, linux-arm-msm, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The alternative stub functions are listed as global, which produces
a build failure in some configs:
In file included from drivers/accel/qaic/qaic_drv.c:31:
drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes]
16 | int qaic_bootlog_register(void) { return 0; }
| ^~~~~~~~~~~~~~~~~~~~~
drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes]
17 | void qaic_bootlog_unregister(void) {}
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes]
18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {}
| ^~~~~~~~~~~~~~~~~
Make them static inline as intended.
Fixes: 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/accel/qaic/qaic_debugfs.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/accel/qaic/qaic_debugfs.h b/drivers/accel/qaic/qaic_debugfs.h
index ea3fd1a88405..05e74f84cf9f 100644
--- a/drivers/accel/qaic/qaic_debugfs.h
+++ b/drivers/accel/qaic/qaic_debugfs.h
@@ -13,8 +13,8 @@ int qaic_bootlog_register(void);
void qaic_bootlog_unregister(void);
void qaic_debugfs_init(struct qaic_drm_device *qddev);
#else
-int qaic_bootlog_register(void) { return 0; }
-void qaic_bootlog_unregister(void) {}
-void qaic_debugfs_init(struct qaic_drm_device *qddev) {}
+static inline int qaic_bootlog_register(void) { return 0; }
+static inline void qaic_bootlog_unregister(void) {}
+static inline void qaic_debugfs_init(struct qaic_drm_device *qddev) {}
#endif /* CONFIG_DEBUG_FS */
#endif /* __QAIC_DEBUGFS_H__ */
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/qaic: mark debugfs stub functions as static inline
2024-04-09 13:39 [PATCH] accel/qaic: mark debugfs stub functions as static inline Arnd Bergmann
@ 2024-04-12 15:52 ` Jeffrey Hugo
2024-04-12 15:56 ` Jeffrey Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2024-04-12 15:52 UTC (permalink / raw)
To: Arnd Bergmann, Oded Gabbay, Jacek Lawrynowicz,
Pranjal Ramajor Asha Kanojiya, Carl Vanderlip
Cc: Arnd Bergmann, linux-arm-msm, dri-devel, linux-kernel
On 4/9/2024 7:39 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The alternative stub functions are listed as global, which produces
> a build failure in some configs:
>
> In file included from drivers/accel/qaic/qaic_drv.c:31:
> drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes]
> 16 | int qaic_bootlog_register(void) { return 0; }
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes]
> 17 | void qaic_bootlog_unregister(void) {}
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes]
> 18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {}
> | ^~~~~~~~~~~~~~~~~
>
> Make them static inline as intended.
>
> Fixes: 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Doh. Thank you for addressing this so quickly.
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/qaic: mark debugfs stub functions as static inline
2024-04-09 13:39 [PATCH] accel/qaic: mark debugfs stub functions as static inline Arnd Bergmann
2024-04-12 15:52 ` Jeffrey Hugo
@ 2024-04-12 15:56 ` Jeffrey Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2024-04-12 15:56 UTC (permalink / raw)
To: Arnd Bergmann, Oded Gabbay, Jacek Lawrynowicz,
Pranjal Ramajor Asha Kanojiya, Carl Vanderlip
Cc: Arnd Bergmann, linux-arm-msm, dri-devel, linux-kernel
On 4/9/2024 7:39 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The alternative stub functions are listed as global, which produces
> a build failure in some configs:
>
> In file included from drivers/accel/qaic/qaic_drv.c:31:
> drivers/accel/qaic/qaic_debugfs.h:16:5: error: no previous prototype for 'qaic_bootlog_register' [-Werror=missing-prototypes]
> 16 | int qaic_bootlog_register(void) { return 0; }
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/accel/qaic/qaic_debugfs.h:17:6: error: no previous prototype for 'qaic_bootlog_unregister' [-Werror=missing-prototypes]
> 17 | void qaic_bootlog_unregister(void) {}
> | ^~~~~~~~~~~~~~~~~~~~~~~
> drivers/accel/qaic/qaic_debugfs.h:18:6: error: no previous prototype for 'qaic_debugfs_init' [-Werror=missing-prototypes]
> 18 | void qaic_debugfs_init(struct qaic_drm_device *qddev) {}
> | ^~~~~~~~~~~~~~~~~
>
> Make them static inline as intended.
>
> Fixes: 5f8df5c6def6 ("accel/qaic: Add bootlog debugfs")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Pushed to drm-misc-next
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-12 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-09 13:39 [PATCH] accel/qaic: mark debugfs stub functions as static inline Arnd Bergmann
2024-04-12 15:52 ` Jeffrey Hugo
2024-04-12 15:56 ` Jeffrey Hugo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox