From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH v5 4/6] nvme-rdma: short-circuit reconnect retries
Date: Tue, 9 Apr 2024 16:00:54 +0200 [thread overview]
Message-ID: <20240409140054.GC20883@lst.de> (raw)
In-Reply-To: <20240409093510.12321-5-dwagner@suse.de>
On Tue, Apr 09, 2024 at 11:35:08AM +0200, Daniel Wagner wrote:
> From: Hannes Reinecke <hare@suse.de>
>
> Returning an nvme status from nvme_rdma_setup_ctrl() indicates that the
Shouldn't this an be an a based on my highschool english. Or does
Eeenvme count as a vowel?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-04-09 14:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 9:35 [PATCH v5 0/6] nvme-fabrics: short-circuit connect retries Daniel Wagner
2024-04-09 9:35 ` [PATCH v5 1/6] nvme: authentication error are always non-retryable Daniel Wagner
2024-04-09 13:59 ` Christoph Hellwig
2024-04-09 20:16 ` Sagi Grimberg
2024-04-09 20:26 ` Sagi Grimberg
2024-04-10 6:52 ` Daniel Wagner
2024-04-10 10:21 ` Sagi Grimberg
2024-04-10 12:05 ` Hannes Reinecke
2024-04-10 13:50 ` Sagi Grimberg
2024-04-11 7:11 ` Hannes Reinecke
2024-04-11 8:37 ` Sagi Grimberg
2024-04-09 9:35 ` [PATCH v5 2/6] nvmet: lock config semaphore when accessing DH-HMAC-CHAP key Daniel Wagner
2024-04-09 9:35 ` [PATCH v5 3/6] nvme-tcp: short-circuit reconnect retries Daniel Wagner
2024-04-09 13:59 ` Christoph Hellwig
2024-04-09 20:20 ` Sagi Grimberg
2024-04-10 6:01 ` Hannes Reinecke
2024-04-09 20:40 ` Sagi Grimberg
2024-04-10 10:06 ` Daniel Wagner
2024-04-09 9:35 ` [PATCH v5 4/6] nvme-rdma: " Daniel Wagner
2024-04-09 14:00 ` Christoph Hellwig [this message]
2024-04-09 14:19 ` Keith Busch
2024-04-09 20:21 ` Sagi Grimberg
2024-04-09 20:28 ` Sagi Grimberg
2024-04-12 2:50 ` Keith Busch
2024-04-09 9:35 ` [PATCH v5 5/6] nvme-fc: use nvme_ctrl_reconnect to decide reconnect attempts Daniel Wagner
2024-04-09 14:01 ` Christoph Hellwig
2024-04-09 9:35 ` [PATCH v5 6/6] nvmet: return DHCHAP status codes from nvmet_setup_auth() Daniel Wagner
2024-04-09 14:03 ` Christoph Hellwig
2024-04-09 20:23 ` Sagi Grimberg
2024-04-10 6:45 ` Hannes Reinecke
2024-04-12 0:35 ` [PATCH v5 0/6] nvme-fabrics: short-circuit connect retries Keith Busch
2024-04-12 7:24 ` Daniel Wagner
2024-04-12 15:24 ` Keith Busch
2024-04-14 8:34 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240409140054.GC20883@lst.de \
--to=hch@lst.de \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox