From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79FE913D535; Wed, 10 Apr 2024 08:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712737000; cv=none; b=B+nytPUtFCoo0TZ1i6Tp1a/DzKuF+LNIUuFCgvf6U0DMLCP0CtVemkcALrkeyzlALQeJoxKnE2q2604J/KpURw9d+VUkLXK72NxwN7rChhVD51hotQ+qbDyWl3Th5ZJJFCard8vio73s3IcW+FXT1lKDEWLrZc2nN7JDIakz2ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712737000; c=relaxed/simple; bh=FDNF2wmT8OB0NT6HpCnZmJIyMluRORrD+x/eYATX778=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jbvqJvnLoXT6Q8BGkTwPVzQj+oylAA2p89BhiQKtB2++c5A+l5GsZUqanChUVIKxnxrG2WWn5JZwMXmbA4R1mrQb8mjpf+LALva3FDuWxdPcrwmJyjysVlM+4fULlRCRISwed1V5+MqvM9LbeCPWUZXqNCNF//KcjcnrU5JCN6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=LPzcYQt3; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="LPzcYQt3" Received: by mail.gandi.net (Postfix) with ESMTPSA id 48B761C0008; Wed, 10 Apr 2024 08:16:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1712736990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3l7juaQsm3ZOw7R2jPwEJbaXnMdcb15KGyFHILQn1mM=; b=LPzcYQt3F3CRP5FNuubXlTCOOeIhU6rNVeViLrj2rA2IKiwd3hegTuRV9upZpPJrMptNEm o2zyb21HQuMeiWf1YqFSgcdSm8s1r5Mtx2BGBkEXGlgkL3gVfhI9PimvovPqypXOOdA4lq byMHz9ECpXcdz725MF87wMOaQYAJnhVRXQoyNJRjEziHZ+/m2U5wqChBq3hyCfqbEObozS Jen47TlIGqMpGskw1BDGurn//AB5oxQWInw36qXxsYIFlje14LMHeaokHx7O4L5LgxiDJ0 4e4dKi7/EoQqfrtuqD0MJWJakBRedyDdULFm1AqA0hYxOMDu2T9SZvisLhu8cA== Date: Wed, 10 Apr 2024 10:16:27 +0200 From: Maxime Chevallier To: Nathan Chancellor Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?UTF-8?B?S8O2cnk=?= Maincent , Jesse Brandeburg , Jonathan Corbet , Marek =?UTF-8?B?QmVow7pu?= , Piergiorgio Beruto , Oleksij Rempel , =?UTF-8?B?Tmljb2zDsg==?= Veronese , Simon Horman , mwojtas@chromium.org Subject: Re: [PATCH net-next v11 01/13] net: phy: Introduce ethernet link topology representation Message-ID: <20240410101627.53bfdebf@device-28.home> In-Reply-To: <20240409201553.GA4124869@dev-arch.thelio-3990X> References: <20240404093004.2552221-1-maxime.chevallier@bootlin.com> <20240404093004.2552221-2-maxime.chevallier@bootlin.com> <20240409201553.GA4124869@dev-arch.thelio-3990X> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: maxime.chevallier@bootlin.com Hello Nathan, On Tue, 9 Apr 2024 13:15:53 -0700 Nathan Chancellor wrote: > Hi Maxime, > > On Thu, Apr 04, 2024 at 11:29:51AM +0200, Maxime Chevallier wrote: [...] > I bisected a crash that I see on one of my test devices to this change > in -next as commit 6916e461e793 ("net: phy: Introduce ethernet link > topology representation"). Here is the stack trace passed through > scripts/decode_stacktrace.sh: [...] > [ 5.626535] ? phy_link_topo_add_phy (drivers/net/phy/phy_link_topology.c:46) libphy > [ 5.627954] ? _raw_spin_lock (arch/x86/include/asm/atomic.h:115 (discriminator 4) include/linux/atomic/atomic-arch-fallback.h:2170 (discriminator 4) include/linux/atomic/atomic-instrumented.h:1302 (discriminator 4) include/asm-generic/qspinlock.h:111 (discriminator 4) include/linux/spinlock.h:187 (discriminator 4) include/linux/spinlock_api_smp.h:134 (discriminator 4) kernel/locking/spinlock.c:154 (discriminator 4)) > [ 5.627963] phy_link_topo_add_phy (include/linux/xarray.h:977 drivers/net/phy/phy_link_topology.c:80) libphy > [ 5.629462] phy_attach_direct (drivers/net/phy/phy_device.c:1516) libphy > [ 5.629504] phylink_connect_phy (drivers/net/phy/phylink.c:1983) phylink > [ 5.631030] ax88772_bind (drivers/net/usb/asix_devices.c:710 drivers/net/usb/asix_devices.c:919) asix > [ 5.631049] usbnet_probe (drivers/net/usb/usbnet.c:1745) usbnet I've run some tests on an arm64 board using an USB to Ethernet adapter that uses the same driver (It also goes through ax88772_bind() ) but I don't reproduce the error. > If there is any additional information I can provide or patches I can > test, I am more than happy to do so. The next step for me would be to try on an x86_64 box to get closer to the config you used, however could you give me the .config that was used when the bug was triggered ? I'd like to make sure I didn't miss anything related to some of the parts being build as modules for example. Thanks a lot, Maxime > Cheers, > Nathan