Re: Fwd: [PATCH v3 0/3] mailbox: zynqmp: Enable Bufferless IPIs for Versal based SOCs

Jassi Brar
2024-05-01T01:39:13Z

On Thu, Apr 25, 2024 at 9:40 AM Ben Levinsky <ben.levinsky@amd.com> wrote:
>
> Ping For Review

It's a beautiful patchset :)

-jassi

> > -------- Forwarded Message --------
> > Subject: [PATCH v3 0/3] mailbox: zynqmp: Enable Bufferless IPIs for Versal based SOCs
> > Date: Wed, 10 Apr 2024 10:08:22 -0700
> > From: Ben Levinsky <ben.levinsky@amd.com>
> > To: jassisinghbrar@gmail.com, michal.simek@amd.com, shubhrajyoti.datta@amd.com, tanmay.shah@amd.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
> >
> > For Xilinx-AMD Versal and Versal NET SOC's there exist also
> > inter-processor-interrupts (IPIs) without IPI Message Buffers. For these
> > enable use of IPI Mailbox driver for send/receive as well.
> >
> > This is enabled with new compatible string: "xlnx,versal-ipi-mailbox"
> >
> > Original, buffered usage for ZynqMP based SOC is still supported.
> >
> > Note that Versal bindings are already present in xlnx,zynqmp-ipi-mailbox.yaml
> >
> > v2:
> > - formatting in 2/3 patch
> > - remove extra handling in 3/3 versal_ipi_setup()
> > v3:
> > 1/3 - removed additional newline to avoid
> > ./scripts/checkpatch.pl --strict -f drivers/mailbox/zynqmp-ipi-mailbox.c
> > CHECK: Please don't use multiple blank lines
> > #434: FILE: drivers/mailbox/zynqmp-ipi-mailbox.c:434:
> > +
> > +
> > 2/3 - remove unused variable dev
> > drivers/mailbox/zynqmp-ipi-mailbox.c:565:24: warning: variable 'dev' set but not
> > used [-Wunused-but-set-variable]
> > struct device *mdev, *dev;
> > 3/3 - remove unused variable dev
> > ^
> > drivers/mailbox/zynqmp-ipi-mailbox.c:666:24: warning: variable 'dev' set but not
> > used [-Wunused-but-set-variable]
> > struct device *mdev, *dev;
> > ^
> >
> > Ben Levinsky (3):
> > mailbox: zynqmp: Move of_match structure closer to usage
> > mailbox: zynqmp: Move buffered IPI setup to of_match selected routine
> > mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's
> >
> > drivers/mailbox/zynqmp-ipi-mailbox.c | 257 ++++++++++++++++++++++-----
> > 1 file changed, 212 insertions(+), 45 deletions(-)
> >