From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1652117BB05 for ; Wed, 10 Apr 2024 17:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712769152; cv=none; b=JP517FQ0aol+klkh1fN8NOeFXUzTQHZxkSM/WUgK71k367vy1Axbto47dOKlwTihIYQq4KZLGeGn7gp5VtE2nqpuatj58zA8nATyw/f15MYxlgv9XIXCdEN18TAnx8HcAL+zCQzyv/wbKE0Vx1DckJQ887i7GZisfqbpnk1BCp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712769152; c=relaxed/simple; bh=EOTo2RqiITH0j5nR8vNeTQXVXsztHoLuLmr01MLLq/c=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=X+L6AOBy2j2TwIhdB3FtX4bIB8rNv/OMpVQC1jx5cW2jmTebt+iJ2AyxYpYjeZ3O4/x20LvIDnjWbuucf0eyln1YHx5YuO4qeTP1MOMzSTxVi3zPkocNyS/jzlFS8a8pRWdOFCqOzJ4JfFH98JQ5Pr9ihS7bSyz9T55fGQkzRgU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VF8Qg369qz6K9MB; Thu, 11 Apr 2024 01:07:39 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 0FC8A1402C7; Thu, 11 Apr 2024 01:12:27 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 18:12:26 +0100 Date: Wed, 10 Apr 2024 18:12:26 +0100 From: Jonathan Cameron To: Robin Murphy CC: , , , Subject: Re: [PATCH] perf/arm-cmn: Set PMU device parent Message-ID: <20240410181226.000068eb@Huawei.com> In-Reply-To: <20240410180403.00004cff@Huawei.com> References: <25d4428df1ddad966c74a3ed60171cd3ca6c8b66.1712682917.git.robin.murphy@arm.com> <20240410180403.00004cff@Huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 10 Apr 2024 18:04:03 +0100 Jonathan Cameron wrote: > On Tue, 9 Apr 2024 18:15:17 +0100 > Robin Murphy wrote: > > > Now that perf supports giving the PMU device a parent, we can use our > > platform device to make the relationship between CMN instances and PMU > > IDs trivially discoverable, from either nominal direction: > > > > root@crazy-taxi:~# ls /sys/devices/platform/ARMHC600:00 | grep cmn > > arm_cmn_0 > > root@crazy-taxi:~# realpath /sys/bus/event_source/devices/arm_cmn_0/.. > > /sys/devices/platform/ARMHC600:00 > > > > Signed-off-by: Robin Murphy > Nice. I'd forgotten all about this :( > > https://lore.kernel.org/all/20230404134225.13408-1-Jonathan.Cameron@huawei.com/ > still has a bunch of these + there were many I never looked into. > > Guess I should respin that series though probably 50% at least still apply. Ironically other than this one, almost the only ones that didn't go in cleanly are the hisilicon drivers where there was some churn. Will, if you 'want' to pick any of those up directly feel free, if not I'll sent them out again in a few days time (and check there weren't any requests for changes buried in that rather extensive thread!) Jonathan > > J > > > > --- > > drivers/perf/arm-cmn.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > > index 7ef9c7e4836b..b2c607cf3ad7 100644 > > --- a/drivers/perf/arm-cmn.c > > +++ b/drivers/perf/arm-cmn.c > > @@ -2482,6 +2482,7 @@ static int arm_cmn_probe(struct platform_device *pdev) > > cmn->cpu = cpumask_local_spread(0, dev_to_node(cmn->dev)); > > cmn->pmu = (struct pmu) { > > .module = THIS_MODULE, > > + .parent = cmn->dev, > > .attr_groups = arm_cmn_attr_groups, > > .capabilities = PERF_PMU_CAP_NO_EXCLUDE, > > .task_ctx_nr = perf_invalid_context, > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel