[GIT PULL for v6.9-rc4] media fixes

[GIT PULL for v6.9-rc4] media fixes

[Mauro Carvalho Chehab]

Hi Linus,

Please pull from:
  git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v6.9-2

For:
  - some fixes causing oops on mediatec vcodec encoder/decoder.

Regards,
Mauro

---


The following changes since commit 4cece764965020c22cff7665b18a012006359095:

  Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v6.9-2

for you to fetch changes up to d353c3c34af08cfd4eaafc8c55f664eacec274ee:

  media: mediatek: vcodec: support 36 bits physical address (2024-03-26 09:52:59 +0100)

----------------------------------------------------------------
media fixes for v6.9-rc4

----------------------------------------------------------------
Irui Wang (1):
      media: mediatek: vcodec: Handle VP9 superframe bitstream with 8 sub-frames

Nicolas Dufresne (1):
      media: mediatek: vcodec: Fix oops when HEVC init fails

Yunfei Dong (3):
      media: mediatek: vcodec: adding lock to protect decoder context list
      media: mediatek: vcodec: adding lock to protect encoder context list
      media: mediatek: vcodec: support 36 bits physical address

 .../media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c |  8 ++++----
 .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.c     |  5 +++++
 .../platform/mediatek/vcodec/decoder/mtk_vcodec_dec_drv.h     |  2 ++
 .../mediatek/vcodec/decoder/vdec/vdec_hevc_req_multi_if.c     |  2 +-
 .../media/platform/mediatek/vcodec/decoder/vdec/vdec_vp8_if.c |  2 +-
 .../media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_if.c | 11 ++++++-----
 .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c        |  4 ++--
 drivers/media/platform/mediatek/vcodec/decoder/vdec_vpu_if.c  |  2 ++
 .../platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.c     |  5 +++++
 .../platform/mediatek/vcodec/encoder/mtk_vcodec_enc_drv.h     |  2 ++
 drivers/media/platform/mediatek/vcodec/encoder/venc_vpu_if.c  |  2 ++
 11 files changed, 32 insertions(+), 13 deletions(-)

Re: [GIT PULL for v6.9-rc4] media fixes

[Linus Torvalds]

On Wed, 10 Apr 2024 at 09:39, Mauro Carvalho Chehab <mchehab@kernel.org> wrote:
>
>   - some fixes causing oops on mediatec vcodec encoder/decoder.

Well, I certainly hope it's not the fixes that cause oopses. That
would be the opposite of a fix.

However, having fixed that, I also find some of the fixes in here
rather broken: commit d353c3c34af0 ("media: mediatek: vcodec: support
36 bits physical address") has a "fix" for a cast like this:

-       dec->bs_dma = (unsigned long)bs->dma_addr;
+       dec->bs_dma = (uint64_t)bs->dma_addr;

but the underlying problem was in fact that the cast was WRONG TO EVEN EXIST.

Both 'bs_dma' and 'dma_addr' are integers. The cast is pointless and
wrong. It makes the code look like it is doing something else than
what it's doing, and that something else would be wrong anyway (ie if
it is a cast from a pointer, it would be doubly wrong).

IOW, as far as I can tell, the fix *should* have been to just remove
the cast entirely since it was pointless.

I've pulled this, but please people - make the pull request
description make sense, and when fixing bugs, please think about the
code a bit more than just do a mindless conversion.

           Linus

Re: [GIT PULL for v6.9-rc4] media fixes

[pr-tracker-bot]

The pull request you sent on Wed, 10 Apr 2024 18:38:52 +0200:

> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media tags/media/v6.9-2

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/9875c0beb8adaab602572b983fb59dbd761d5882

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html