From: Parker Newman <parker@finest.io>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org,
Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH 1/2] serial: exar: add missing CTI/Exar PCI IDs to include/linux/pci_ids.h
Date: Thu, 11 Apr 2024 12:22:48 -0400 [thread overview]
Message-ID: <20240411122248.5070c840@SWDEV2.connecttech.local> (raw)
In-Reply-To: <2024041124-blah-obligate-5f6d@gregkh>
On Thu, 11 Apr 2024 17:54:45 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> On Thu, Apr 11, 2024 at 11:29:26AM -0400, parker@finest.io wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > - Added missing CTI serial car PCI IDs
> > - Added missing Exar XR17V25X PCI IDs
> > - Moved XR17V4358 and XR17V8358 PCI ID defines to pci_ids.h
>
> Did you read the top of the pci_ids.h file? Don't add new ids there
> unless it is going to be needed in multiple files please.
>
> thanks,
>
> greg k-h
No sorry I missed that... I was just trying to consolidate them all
in one place.
Would it be better to move all the Connect Tech sub-IDs from
pci_ids.h into 8250_exar.c? Or should I just add the missing ones
to 8250_exar.c instead of pci_ids.h?
Thank you,
-Parker
next prev parent reply other threads:[~2024-04-11 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 15:29 [PATCH 0/2] serial: exar: add Connect Tech serial cards to Exar driver parker
2024-04-11 15:29 ` [PATCH 1/2] serial: exar: add missing CTI/Exar PCI IDs to include/linux/pci_ids.h parker
2024-04-11 15:54 ` Greg Kroah-Hartman
2024-04-11 16:22 ` Parker Newman [this message]
2024-04-11 17:13 ` Greg Kroah-Hartman
2024-04-11 15:29 ` [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port support to 8250_exar parker
2024-04-11 15:55 ` Greg Kroah-Hartman
2024-04-11 16:28 ` Parker Newman
2024-04-12 4:53 ` kernel test robot
2024-04-12 5:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411122248.5070c840@SWDEV2.connecttech.local \
--to=parker@finest.io \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox