From: Peter Zijlstra <peterz@infradead.org>
To: Beau Belgrave <beaub@linux.microsoft.com>
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com, primiano@google.com,
aahringo@redhat.com, dcook@linux.microsoft.com
Subject: Re: [RFC PATCH 0/4] perf: Correlating user process data to samples
Date: Fri, 12 Apr 2024 09:12:45 +0200 [thread overview]
Message-ID: <20240412071245.GD30852@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20240412001732.475-1-beaub@linux.microsoft.com>
On Fri, Apr 12, 2024 at 12:17:28AM +0000, Beau Belgrave wrote:
> An idea flow would look like this:
> User Task Profile
> do_work(); sample() -> IP + No activity
> ...
> set_activity(123);
> ...
> do_work(); sample() -> IP + activity (123)
> ...
> set_activity(124);
> ...
> do_work(); sample() -> IP + activity (124)
This, start with this, because until I saw this, I was utterly confused
as to what the heck you were on about.
I started by thinking we already have TID in samples so you can already
associate back to user processes and got increasingly confused the
further I went.
What you seem to want to do however is have some task-state included so
you can see what the thread is doing.
Anyway, since we typically run stuff from NMI context, accessing user
data is 'interesting'. As such I would really like to make this work
depend on the call-graph rework that pushes all the user access bits
into return-to-user.
next prev parent reply other threads:[~2024-04-12 7:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 0:17 [RFC PATCH 0/4] perf: Correlating user process data to samples Beau Belgrave
2024-04-12 0:17 ` [RFC PATCH 1/4] perf/core: Introduce perf_prepare_dump_data() Beau Belgrave
2024-04-12 0:17 ` [RFC PATCH 2/4] perf: Introduce PERF_SAMPLE_TLS_USER sample type Beau Belgrave
2024-04-12 0:17 ` [RFC PATCH 3/4] perf/core: Factor perf_output_sample_udump() Beau Belgrave
2024-04-12 0:17 ` [RFC PATCH 4/4] perf/x86/core: Add tls dump support Beau Belgrave
2024-04-12 4:52 ` [RFC PATCH 0/4] perf: Correlating user process data to samples Ian Rogers
2024-04-12 16:28 ` Beau Belgrave
2024-04-12 18:32 ` Mathieu Desnoyers
2024-04-12 7:12 ` Peter Zijlstra [this message]
2024-04-12 16:37 ` Beau Belgrave
2024-04-13 10:53 ` Peter Zijlstra
2024-04-13 12:48 ` Steven Rostedt
2024-04-18 22:53 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240412071245.GD30852@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aahringo@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=beaub@linux.microsoft.com \
--cc=dcook@linux.microsoft.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=primiano@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox