public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Arnd Bergmann <arnd@kernel.org>,
	Gatlin Newhouse <gatlin.newhouse@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] [v3] kbuild: turn on -Wrestrict by default
Date: Mon, 15 Apr 2024 09:14:38 -0700	[thread overview]
Message-ID: <202404150909.E703A96D0@keescook> (raw)
In-Reply-To: <20240415122037.1983124-4-arnd@kernel.org>

On Mon, Apr 15, 2024 at 02:20:34PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> All known -Wrestrict warnings are addressed now, so don't disable the warning
> any more.

Ah, great! Yes, I know Gatlin was also looking at this and doing a bunch
of builds across compiler versions to verify this was ready to do too.
Gatlin, are you able to provide a "Tested-by:" tag for this patch?

-Kees

> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  scripts/Makefile.extrawarn | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 8b3f5b62b837..95466a04d51b 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -98,7 +98,6 @@ else
>  # Suppress them by using -Wno... except for W=1.
>  KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
>  KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
> -KBUILD_CFLAGS += $(call cc-disable-warning, restrict)
>  KBUILD_CFLAGS += $(call cc-disable-warning, packed-not-aligned)
>  KBUILD_CFLAGS += $(call cc-disable-warning, format-overflow)
>  KBUILD_CFLAGS += $(call cc-disable-warning, format-truncation)
> -- 
> 2.39.2
> 

-- 
Kees Cook

  reply	other threads:[~2024-04-15 16:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15 12:20 [PATCH 0/6] [v3] kbuild: enable more warnings by default Arnd Bergmann
2024-04-15 12:20 ` [PATCH 1/6] [v3] kbuild: turn on -Wextra " Arnd Bergmann
2024-04-15 16:16   ` Kees Cook
2024-04-15 12:20 ` [PATCH 2/6] [v3] kbuild: remove redundant extra warning flags Arnd Bergmann
2024-04-15 12:20 ` [PATCH 3/6] [v3] kbuild: turn on -Wrestrict by default Arnd Bergmann
2024-04-15 16:14   ` Kees Cook [this message]
2024-05-28 13:01   ` Geert Uytterhoeven
2024-04-15 12:20 ` [PATCH 4/6] [v3] kbuild: enable -Wformat-truncation on clang Arnd Bergmann
2024-04-15 12:20 ` [PATCH 5/6] [v3] kbuild: enable -Wcast-function-type-strict unconditionally Arnd Bergmann
2024-04-15 16:15   ` Kees Cook
2024-04-15 12:20 ` [PATCH 6/6] [v3] kbuild: enable -Wstringop-truncation globally Arnd Bergmann
2024-04-15 16:15   ` Kees Cook
  -- strict thread matches above, loose matches on Subject: below --
2024-04-15 16:55 [PATCH 3/6] [v3] kbuild: turn on -Wrestrict by default Gatlin Newhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202404150909.E703A96D0@keescook \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=gatlin.newhouse@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox