From: Herman van Hazendonk <github.com@herrie.org>
To: sre@kernel.org
Cc: benwolsieffer@gmail.com, chris.chapuis@gmail.com,
Herman van Hazendonk <github.com@herrie.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] power: supply: max8903: configure USUS as output
Date: Mon, 15 Apr 2024 17:17:33 +0200 [thread overview]
Message-ID: <20240415151733.1986047-1-github.com@herrie.org> (raw)
The USUS pin was mistakenly configured as an input, when it should be an
output that specifies whether the USB power input is suspended. In addition
to fixing the pin mode, this patch also suspends the USB input when a DC
charger is connected, which should result in a slight reduction in USB
quiescent current.
Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
---
drivers/power/supply/max8903_charger.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/supply/max8903_charger.c
index e65d0141f260..dd1cf77b101d 100644
--- a/drivers/power/supply/max8903_charger.c
+++ b/drivers/power/supply/max8903_charger.c
@@ -102,6 +102,11 @@ static irqreturn_t max8903_dcin(int irq, void *_data)
if (data->dcm)
gpiod_set_value(data->dcm, ta_in);
+ /* Set USB-Suspend 1:Suspended 0:Active */
+ if (data->usus)
+ gpiod_set_value(data->usus, ta_in);
+
+
/* Charger Enable / Disable */
if (data->cen) {
int val;
@@ -310,7 +315,15 @@ static int max8903_setup_gpios(struct platform_device *pdev)
"failed to get FLT GPIO");
gpiod_set_consumer_name(data->flt, data->psy_desc.name);
- data->usus = devm_gpiod_get_optional(dev, "usus", GPIOD_IN);
+ /*
+ * Suspend the USB input if the DC charger is connected.
+ *
+ * The USUS line should be marked GPIO_ACTIVE_HIGH in the
+ * device tree. Driving it low will enable the USB charger
+ * input.
+ */
+ flags = ta_in ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
+ data->usus = devm_gpiod_get_optional(dev, "usus", flags);
if (IS_ERR(data->usus))
return dev_err_probe(dev, PTR_ERR(data->usus),
"failed to get USUS GPIO");
reply other threads:[~2024-04-15 15:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415151733.1986047-1-github.com@herrie.org \
--to=github.com@herrie.org \
--cc=benwolsieffer@gmail.com \
--cc=chris.chapuis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox