From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] ASoC: dt-bindings: fsl-esai: Remove 'fsl,*' from required list
Date: Mon, 15 Apr 2024 17:29:22 -0500 [thread overview]
Message-ID: <20240415222922.GA198321-robh@kernel.org> (raw)
In-Reply-To: <20240411-esai_arm_dts_warning-v1-1-5e1a7c7be9b9@nxp.com>
On Thu, Apr 11, 2024 at 01:07:45PM -0400, Frank Li wrote:
> fsl,fifo-depth have default value 64 in driver(sound/soc/fsl/fsl_esai.c).
>
> fsl,esai-synchronous is flag(bool) type. It doesn't make sense to put flag
> type into 'required'.
>
> Fix warning:
>
> arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@2024000: 'fsl,fifo-depth' is a required property
> arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@2024000: 'fsl,esai-synchronous' is a required property
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/sound/fsl,esai.yaml | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,esai.yaml b/Documentation/devicetree/bindings/sound/fsl,esai.yaml
> index f167f1634d7e3..66f20ecaa42b4 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,esai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,esai.yaml
> @@ -70,7 +70,7 @@ properties:
> description:
> The number of elements in the transmit and receive
> FIFOs. This number is the maximum allowed value for
> - TFCR[TFWM] or RFCR[RFWM].
> + TFCR[TFWM] or RFCR[RFWM]. Default value is 64.
default: 64
>
> fsl,esai-synchronous:
> $ref: /schemas/types.yaml#/definitions/flag
> @@ -95,8 +95,6 @@ required:
> - clock-names
> - dmas
> - dma-names
> - - fsl,fifo-depth
> - - fsl,esai-synchronous
>
> unevaluatedProperties: false
>
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-04-15 22:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 17:07 [PATCH 0/4] arm: dts: nxp: imx6: fix esai related dtb_check warning Frank Li
2024-04-11 17:07 ` [PATCH 1/4] ASoC: dt-bindings: fsl-esai: Remove 'fsl,*' from required list Frank Li
2024-04-15 22:29 ` Rob Herring [this message]
2024-04-11 17:07 ` [PATCH 2/4] ASoC: dt-bindings: fsl-esai: Add ref: dai-common.yaml Frank Li
2024-04-15 22:29 ` Rob Herring
2024-04-11 17:07 ` [PATCH 3/4] arm: dts: nxp: imx6sx: fix esai related warning when do dtb_check Frank Li
2024-04-11 17:07 ` [PATCH 4/4] arm: dts: nxp: imx6qdl: fix esai clock " Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240415222922.GA198321-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox