[PATCH 31/35] media: cx231xx: Refator return path

Ricardo Ribalda
2024-04-15T19:35:03Z

This is a nop, but let cocci now that this is not a good candidate for
min()

drivers/media/usb/cx231xx/cx231xx-i2c.c:353:15-16: WARNING opportunity for min()
drivers/media/usb/cx231xx/cx231xx-i2c.c:262:15-16: WARNING opportunity for min()
drivers/media/usb/cx231xx/cx231xx-i2c.c:326:15-16: WARNING opportunity for min()
drivers/media/usb/cx231xx/cx231xx-i2c.c:176:15-16: WARNING opportunity for min()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/usb/cx231xx/cx231xx-i2c.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c
index c6659253c6fb..28de72856c90 100644
--- a/drivers/media/usb/cx231xx/cx231xx-i2c.c
+++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c
@@ -173,7 +173,9 @@ static int cx231xx_i2c_send_bytes(struct i2c_adapter *i2c_adap,
status = dev->cx231xx_send_usb_command(bus, &req_data);
}

- return status < 0 ? status : 0;
+ if (status < 0)
+ return status;
+ return 0;
}

/*
@@ -259,7 +261,9 @@ static int cx231xx_i2c_recv_bytes(struct i2c_adapter *i2c_adap,
status = dev->cx231xx_send_usb_command(bus, &req_data);
}

- return status < 0 ? status : 0;
+ if (status < 0)
+ return status;
+ return 0;
}

/*
@@ -323,7 +327,9 @@ static int cx231xx_i2c_recv_bytes_with_saddr(struct i2c_adapter *i2c_adap,
/* usb send command */
status = dev->cx231xx_send_usb_command(bus, &req_data);

- return status < 0 ? status : 0;
+ if (status < 0)
+ return status;
+ return 0;
}

/*
@@ -350,7 +356,9 @@ static int cx231xx_i2c_check_for_device(struct i2c_adapter *i2c_adap,
/* usb send command */
status = dev->cx231xx_send_usb_command(bus, &req_data);

- return status < 0 ? status : 0;
+ if (status < 0)
+ return status;
+ return 0;
}

/*

--
2.44.0.683.g7961c838ac-goog