From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 106E327715 for ; Tue, 16 Apr 2024 04:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713242493; cv=none; b=RAni4G0WOJJMKMQbJLFd0MxIqatP6SOPo6Gdy9uVYxfrh0VoeEeyCd4mOUitDOHC6efk78FPyXOfKHB/aCwBcIPz7lP/a52VUPCFtwxybCRrWqLfaNn4xEryQ7V1ySQmQISpg1QHRG3PioxtYBIYoFn8foEDkuW5wdodAFfyVcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713242493; c=relaxed/simple; bh=DqDyd4MpI+rvYMYAT3Ft5xs95IMJydJhHOHuJjyBxW4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pPbY9i7b0NYgOJOCirJ49oR/xn6/+uXcJBKZSuNZjNtjIfoGZ7hiMENDQMMmTjQNJ/+IW9pDUm7B0A7Ta/A4bGglLNGXNLo9LDElbjL0M35vLlgy1wbugVVsOFAnJzrg+susjv0iADBvxWkaN9U0e9m1SLcQKYJqw7ZyTPx+fLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QA+XMZEQ; arc=none smtp.client-ip=209.85.160.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QA+XMZEQ" Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-22fa7e4b0beso2581224fac.1 for ; Mon, 15 Apr 2024 21:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1713242490; x=1713847290; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zlvfKPvFfqMVTjgmkdQ2dgHupdBvuhJAjVeekD23sMY=; b=QA+XMZEQ4TSKlDwKnkstTwNqATtBiFbsIwW6mmZH78ughkAzpgyenMvV1Lpd/vMyHP 7NTsFHch3jvOiJ+obKYa+FzwWUXuVaEChF4zTRRV/GQklNftpHjFe/lFZUezfns1dkt4 k677k7WQs69PISiVPzIYtOUUow0YCd559kxZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713242490; x=1713847290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zlvfKPvFfqMVTjgmkdQ2dgHupdBvuhJAjVeekD23sMY=; b=TgCLIaywQzzxXrgMMmb27N0yTDWFaUeOzKKRgkj+D8xzx45H1haXusfCE9xHy1gE7U lfLjoVa9clYHXB3yNXN8GIIf11mdsEBH16Gr6PxVYRRaqZuhDuRLRyPkW2wjTLoV77+e stby7+s3yH90/YSJcJP5VtzrR+tXflGCpHref5Ci2WMA8wVBOrPImMHVWvVY3DaxZmJU eUovpVaw5sFzzwElreMVVPDlHNtnaF+0LZm5k9Xp9Hx5N31OWkbnenLDNPcZ7ew5h9Wk Dp3CcJ4qT109lxvGJKl/Gi6vnShjLgZ+/shnWoDTWKlzCMeqNOH1O72/tifkax3KhPhp /0bQ== X-Forwarded-Encrypted: i=1; AJvYcCUZKiDHIbrD4kNe3JI44PnmNKbvHlB3+fhnGGgDWnl4PxwBa7I6QiZHxvqEuA0pmpgYCuFdbh/z7StfhI8UYGS47EhfMWr91n3Ce2gc X-Gm-Message-State: AOJu0Yz3vVJ4kV/2nNlkia+W8G/U6Y2u4+d4EBElL9UGMA8lK3mgrtRy nwg2aqql3xYyN5OqtMoSyUThGXUPld44DCmDicPPltGZPOOuI5ZYOgKb+SaFNw== X-Google-Smtp-Source: AGHT+IFGNPBipDIE0AiNQc/Cqlxd5431Vef5ObfevA6hF44fnzurKBxD1B4lS2oVTJREu9b1YFAdCg== X-Received: by 2002:a05:6870:89a4:b0:22d:fcf9:bd97 with SMTP id f36-20020a05687089a400b0022dfcf9bd97mr15408827oaq.26.1713242490147; Mon, 15 Apr 2024 21:41:30 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:1137:d3d7:a09d:5379]) by smtp.gmail.com with ESMTPSA id r4-20020a056a00216400b006edd05e3751sm8284703pff.176.2024.04.15.21.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 21:41:29 -0700 (PDT) Date: Tue, 16 Apr 2024 13:41:19 +0900 From: Sergey Senozhatsky To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 04/35] media: uvcvideo: Use max() macro Message-ID: <20240416044119.GB14947@google.com> References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> <20240415-fix-cocci-v1-4-477afb23728b@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-4-477afb23728b@chromium.org> On (24/04/15 19:34), Ricardo Ribalda wrote: > It makes the code slightly more clear and makes cocci incredibly happy: > > drivers/media/usb/uvc/uvc_ctrl.c:839:22-23: WARNING opportunity for max() > > Signed-off-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky