From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: mka@chromium.org, andersson@kernel.org,
quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com,
quic_jponduru@quicinc.com, quic_subashab@quicinc.com,
elder@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net-next 3/7] net: ipa: include "ipa_interrupt.h" where needed
Date: Tue, 16 Apr 2024 18:10:14 -0500 [thread overview]
Message-ID: <20240416231018.389520-4-elder@linaro.org> (raw)
In-Reply-To: <20240416231018.389520-1-elder@linaro.org>
The IPA structure contains an ipa_interrupt structure pointer, and
that structure is declared in "ipa.h". There is no need to include
"ipa_interrupt.h" in that header file.
Instead, include "ipa_interrupt.h" in the three source files (in
addition to "ipa_main.c") that actually use the functions that are
declared there.
Similarly, three files use symbols defined in "ipa_reg.h" but do not
include that file; include it.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/ipa.h | 1 -
drivers/net/ipa/ipa_cmd.c | 1 +
drivers/net/ipa/ipa_endpoint.c | 2 ++
drivers/net/ipa/ipa_power.c | 3 ++-
drivers/net/ipa/ipa_uc.c | 4 +++-
5 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ipa/ipa.h b/drivers/net/ipa/ipa.h
index 968175019a5e3..cdfd579af5b94 100644
--- a/drivers/net/ipa/ipa.h
+++ b/drivers/net/ipa/ipa.h
@@ -14,7 +14,6 @@
#include "ipa_mem.h"
#include "ipa_qmi.h"
#include "ipa_endpoint.h"
-#include "ipa_interrupt.h"
struct clk;
struct icc_path;
diff --git a/drivers/net/ipa/ipa_cmd.c b/drivers/net/ipa/ipa_cmd.c
index 2e7762171e480..969b93fe5c495 100644
--- a/drivers/net/ipa/ipa_cmd.c
+++ b/drivers/net/ipa/ipa_cmd.c
@@ -14,6 +14,7 @@
#include "gsi_trans.h"
#include "ipa.h"
#include "ipa_endpoint.h"
+#include "ipa_reg.h"
#include "ipa_table.h"
#include "ipa_cmd.h"
#include "ipa_mem.h"
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
index 4e8849c1f32d9..8284b0a1178c3 100644
--- a/drivers/net/ipa/ipa_endpoint.c
+++ b/drivers/net/ipa/ipa_endpoint.c
@@ -19,9 +19,11 @@
#include "ipa_cmd.h"
#include "ipa_mem.h"
#include "ipa_modem.h"
+#include "ipa_reg.h"
#include "ipa_table.h"
#include "ipa_gsi.h"
#include "ipa_power.h"
+#include "ipa_interrupt.h"
/* Hardware is told about receive buffers once a "batch" has been queued */
#define IPA_REPLENISH_BATCH 16 /* Must be non-zero */
diff --git a/drivers/net/ipa/ipa_power.c b/drivers/net/ipa/ipa_power.c
index 41ca7ef5e20fc..42d728f08c930 100644
--- a/drivers/net/ipa/ipa_power.c
+++ b/drivers/net/ipa/ipa_power.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved.
- * Copyright (C) 2018-2022 Linaro Ltd.
+ * Copyright (C) 2018-2024 Linaro Ltd.
*/
#include <linux/clk.h>
@@ -15,6 +15,7 @@
#include "ipa.h"
#include "ipa_power.h"
+#include "ipa_interrupt.h"
#include "ipa_endpoint.h"
#include "ipa_modem.h"
#include "ipa_data.h"
diff --git a/drivers/net/ipa/ipa_uc.c b/drivers/net/ipa/ipa_uc.c
index bfd5dc6dab432..17352f21d5f87 100644
--- a/drivers/net/ipa/ipa_uc.c
+++ b/drivers/net/ipa/ipa_uc.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2012-2018, The Linux Foundation. All rights reserved.
- * Copyright (C) 2018-2022 Linaro Ltd.
+ * Copyright (C) 2018-2024 Linaro Ltd.
*/
#include <linux/types.h>
@@ -10,8 +10,10 @@
#include <linux/pm_runtime.h>
#include "ipa.h"
+#include "ipa_reg.h"
#include "ipa_uc.h"
#include "ipa_power.h"
+#include "ipa_interrupt.h"
/**
* DOC: The IPA embedded microcontroller
--
2.40.1
next prev parent reply other threads:[~2024-04-16 23:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 23:10 [PATCH net-next 0/7] net: ipa: header hygiene Alex Elder
2024-04-16 23:10 ` [PATCH net-next 1/7] net: ipa: include some standard header files Alex Elder
2024-04-16 23:10 ` [PATCH net-next 2/7] net: ipa: remove unneeded standard includes Alex Elder
2024-04-16 23:10 ` Alex Elder [this message]
2024-04-16 23:10 ` [PATCH net-next 4/7] net: ipa: add some needed struct declarations Alex Elder
2024-04-16 23:10 ` [PATCH net-next 5/7] net: ipa: eliminate unneeded " Alex Elder
2024-04-16 23:10 ` [PATCH net-next 6/7] net: ipa: more include file cleanup Alex Elder
2024-04-16 23:10 ` [PATCH net-next 7/7] net: ipa: sort all includes Alex Elder
2024-04-18 11:10 ` [PATCH net-next 0/7] net: ipa: header hygiene patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416231018.389520-4-elder@linaro.org \
--to=elder@linaro.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_avuyyuru@quicinc.com \
--cc=quic_cpratapa@quicinc.com \
--cc=quic_jponduru@quicinc.com \
--cc=quic_subashab@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox