Re: [PATCH 00/12] ASoC: doc: dapm: various improvements

Alexandre Belloni
2024-04-16T21:23:55Z

On 16/04/2024 07:56:06+0200, Luca Ceresoli wrote:
> This series applies various improvements to the DAPM documentation: a
> rewrite of a few sections for clarity, style improvements and typo fixes.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
> Luca Ceresoli (12):
> ASoC: doc: dapm: fix typos
> ASoC: doc: dapm: fix struct name
> ASoC: doc: dapm: minor rewording

I'm wondering whether you could improve this patch by not rewrapping the
whole paragraph.

> ASoC: doc: dapm: remove dash after colon
> ASoC: doc: dapm: clarify it's an internal API
> ASoC: doc: dapm: replace "map" with "graph"
> ASoC: doc: dapm: extend initial descrption
> ASoC: doc: dapm: describe how widgets and routes are registered
> ASoC: doc: dapm: fix and improve section "Registering DAPM controls"
> ASoC: doc: dapm: improve section "Codec/DSP Widget Interconnections"
> ASoC: doc: dapm: update section "DAPM Widget Events"
> ASoC: doc: dapm: update event types
>
> Documentation/sound/soc/dapm-graph.svg | 375 +++++++++++++++++++++++++++++++++
> Documentation/sound/soc/dapm.rst | 178 ++++++++++------
> 2 files changed, 494 insertions(+), 59 deletions(-)
> ---
> base-commit: 8f2c057754b25075aa3da132cd4fd4478cdab854
> change-id: 20240315-dapm-docs-79bd51f267db
>
> Best regards,
> --
> Luca Ceresoli <luca.ceresoli@bootlin.com>
>

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering