From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE2A16C6A4 for ; Thu, 18 Apr 2024 14:20:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713450015; cv=none; b=JY/mV0HMYRFEVuO4RYfpU5DjrPeZxyTpmVpwI4E46c6Uu8FYFZZ7okPj3cQ6eunOrbf9V4oPqUMUr7iv6OipcjFNTFyZyEF6wnMgoSIm/6xmusIQqXTBp6W6CCX1q+M+OZzsvkHdt5WbDBjYQp/mQkuIYTs1qeTLkrSBclTIg/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713450015; c=relaxed/simple; bh=4bNa8afCH4lot+IghKymgJGbI+oGdAQXU26GVAG+67Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DZGOnUD6BgyuwRpjabn5YwUuC19rxYMZqSHExMPeQHH/IlgGzzpCq3eIR7bxHIwGq3/KSVFFffNgubNmZ9bJd9mXvHbkB1Ha8gxIS2ODbsIWFYkBMg7cUmU0TKdDMaT8QBXzq0Zeo0o4xH0sUC7xubUew4ljryWOLNADoH6wfjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=e7SucZRs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="e7SucZRs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713450012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xzDmscmhNUUyb7+nP9/RYULiSYndJ+L0g8+7/DTmi+E=; b=e7SucZRsEtdy+JIv7IcdOs4xalC25DnD8zDCuxObybWhMxDv2K2Q+OwM9HHI8mq0hs2Q7g 2/x9BLeWHScxI1UujHPVm7B0zb2pDK591E/uRQtRBXkRM6jqkhNBrsDyGOk6KMevau8CXk 9c/EEoH5bj0E3zZZ7bwtKMme6Xxt4jY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-362-cwLkf_YmMUKceoMHpXgPAA-1; Thu, 18 Apr 2024 10:20:05 -0400 X-MC-Unique: cwLkf_YmMUKceoMHpXgPAA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 089C41C3F10B; Thu, 18 Apr 2024 14:20:04 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.182]) by smtp.corp.redhat.com (Postfix) with SMTP id 761E4200AD74; Thu, 18 Apr 2024 14:20:00 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 18 Apr 2024 16:18:38 +0200 (CEST) Date: Thu, 18 Apr 2024 16:18:33 +0200 From: Oleg Nesterov To: Thomas Gleixner Cc: LKML , Anna-Maria Behnsen , Frederic Weisbecker , John Stultz , Peter Zijlstra , Ingo Molnar , Stephen Boyd , Eric Biederman Subject: Re: [patch V2 23/50] signal: Remove task argument from dequeue_signal() Message-ID: <20240418141833.GA19794@redhat.com> References: <20240410164558.316665885@linutronix.de> <20240410165552.381760138@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410165552.381760138@linutronix.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 On 04/11, Thomas Gleixner wrote: > > The task pointer which is handed to dequeue_signal() is always current. The > argument along with the first comment about signalfd in that function is > confusing at best. Remove it and use current internally. > > Update the stale comment for dequeue_signal() while at it. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Frederic Weisbecker > --- > fs/signalfd.c | 4 ++-- > include/linux/sched/signal.h | 5 ++--- > kernel/signal.c | 23 ++++++++++------------- Reviewed-by: Oleg Nesterov