From: Peter Zijlstra <peterz@infradead.org>
To: Chen Yu <yu.c.chen@intel.com>
Cc: Tianchen Ding <dtcccc@linux.alibaba.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Abel Wu <wuyun.abel@bytedance.com>
Subject: Re: [PATCH v2 0/2] sched/eevdf: Minor fixes for reweight_entity()
Date: Fri, 19 Apr 2024 10:02:25 +0200 [thread overview]
Message-ID: <20240419080225.GA6345@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ZiIc4mU/RcSPI+WV@chenyu5-mobl2>
On Fri, Apr 19, 2024 at 03:27:30PM +0800, Chen Yu wrote:
> On 2024-03-06 at 10:21:31 +0800, Tianchen Ding wrote:
> > According to the discussion in [1], fix a calculation bug in
> > reweight_entity().
> >
> > [1] https://lore.kernel.org/all/59585184-d13d-46e0-8d68-42838e97a702@bytedance.com/
> >
> > v2:
> > Add fixes tag to the 1st patch.
> >
> > v1: https://lore.kernel.org/all/20240304030042.2690-1-dtcccc@linux.alibaba.com/
> >
> > Tianchen Ding (2):
> > sched/eevdf: Always update V if se->on_rq when reweighting
> > sched/eevdf: Fix miscalculation in reweight_entity() when se is not
> > curr
> >
> > kernel/sched/fair.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > --
> > 2.39.3
> >
>
> Applied this patch set on top of the reweight_entity fix at
> https://lore.kernel.org/lkml/ZiEaKOQwiNEglYtS@chenyu5-mobl2/
> it has passed 100 cycles of trinity test without any issue.
>
> For the whole serie,
>
> Tested-by: Chen Yu <yu.c.chen@intel.com>
OK, grabbed these patches (and made some minor edits), now let me go
stare at that other thread again.
prev parent reply other threads:[~2024-04-19 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 2:21 [PATCH v2 0/2] sched/eevdf: Minor fixes for reweight_entity() Tianchen Ding
2024-03-06 2:21 ` [PATCH v2 1/2] sched/eevdf: Always update V if se->on_rq when reweighting Tianchen Ding
2024-03-06 3:06 ` Abel Wu
2024-04-22 11:39 ` [tip: sched/urgent] " tip-bot2 for Tianchen Ding
2024-03-06 2:21 ` [PATCH v2 2/2] sched/eevdf: Fix miscalculation in reweight_entity() when se is not curr Tianchen Ding
2024-04-22 11:39 ` [tip: sched/urgent] " tip-bot2 for Tianchen Ding
2024-03-13 6:24 ` [PATCH v2 0/2] sched/eevdf: Minor fixes for reweight_entity() K Prateek Nayak
2024-04-08 3:24 ` Tianchen Ding
2024-04-19 7:27 ` Chen Yu
2024-04-19 8:02 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419080225.GA6345@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=dtcccc@linux.alibaba.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wuyun.abel@bytedance.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox