From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03898D52A; Sat, 20 Apr 2024 06:27:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713594448; cv=none; b=NrXwn/I4q7fjSYfuQ+fT9ANkLdARJdyi1vaswazBr7zRc9eul+ydTPLXQjIxsQhTqgerepom8+p7CYfl7ZesG1MT2A3xaFIIZ52hvONega+1gTXBoMQCzx2dBLiQTF76e65ptOvbuJdJrrNxho6fwG0sdBr9zxwQ6ErKrUZSDFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713594448; c=relaxed/simple; bh=3Rv9kxynFCiNH8AU1R2lEpYXFpko+0AQnoUOT+h2Jyg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I8VrpZ0uGfNHC4mzD0NZvtSmrhxT+dJrEGxkWpQYP89OHwbuMRZ9piUtuC1OQRmpXCVeaLxNVeqysexjVYp4hY3hFJh68oe5NuNK3qP2P4llrxJ5Gd0Fc/pgjVLpHiGCvlbm5ITzXP4zeky9bLiaHXIEjsjyMI7SpQ1FUPgauf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wIQjmFR2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wIQjmFR2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 191A9C072AA; Sat, 20 Apr 2024 06:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713594447; bh=3Rv9kxynFCiNH8AU1R2lEpYXFpko+0AQnoUOT+h2Jyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wIQjmFR2eL7dfW/tf0dG3m1+HlC9GWL5lotRyARqlTiYBrZx1RfCNueYDRnfIdBnL 4LGDFPndq8A3e1F6BgYEZ7s3PvWn/tkNwNRxJK2Hy+MR9Qlp9oNFt2bJ9JtfkYUa6O KCSUlwGNstX7TvRLtyzIOCjnNQLerpCnfIzvN5Kw= Date: Sat, 20 Apr 2024 08:27:20 +0200 From: Greg Kroah-Hartman To: Markus Elfring Cc: Wander Lairson Costa , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org, Brendan Higgins , David Gow , Matti Vaittinen , Maxime Ripard , Rae Moar , Shuah Khan , LKML Subject: Re: [PATCH v4 1/2] kunit: unregister the device on error Message-ID: <2024042013-condition-glade-90e4@gregkh> References: <2024041955-strangely-snack-b335@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Apr 19, 2024 at 06:32:05PM +0200, Markus Elfring wrote: > > > kunit_init_device() should unregister the device on bus register error, > > > but mistakenly it tries to unregister the bus. > > > > > > Unregister the device instead of the bus. > … > > Reviewed-by: Greg Kroah-Hartman > > Would you ever like to distinguish hardware register errors from > item registration failures according to further improved commit messages? Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot