Re: [PATCH AUTOSEL 6.6 10/29] memblock tests: fix undefined reference to `BIT'

Suren Baghdasaryan
2024-04-23T02:14:14Z

On Mon, Apr 22, 2024 at 4:56 PM Sasha Levin <sashal@kernel.org> wrote:
>
> From: Wei Yang <richard.weiyang@gmail.com>
>
> [ Upstream commit 592447f6cb3c20d606d6c5d8e6af68e99707b786 ]
>
> commit 772dd0342727 ("mm: enumerate all gfp flags") define gfp flags
> with the help of BIT, while gfp_types.h doesn't include header file for
> the definition. This through an error on building memblock tests.
>
> Let's include linux/bits.h to fix it.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> CC: Suren Baghdasaryan <surenb@google.com>
> CC: Michal Hocko <mhocko@suse.com>
> Link: https://lore.kernel.org/r/20240402132701.29744-4-richard.weiyang@gmail.com
> Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Sasha, are you backporting 772dd0342727 ("mm: enumerate all gfp
flags") to 6.6 and 6.8 kernels? Just checking because I didn't see any
emails about that and can't find it in stable branches. If not, then
this fixup is not needed there.

> ---
> include/linux/gfp_types.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/gfp_types.h b/include/linux/gfp_types.h
> index 6583a58670c57..dfde1e1e321c3 100644
> --- a/include/linux/gfp_types.h
> +++ b/include/linux/gfp_types.h
> @@ -2,6 +2,8 @@
> #ifndef __LINUX_GFP_TYPES_H
> #define __LINUX_GFP_TYPES_H
>
> +#include <linux/bits.h>
> +
> /* The typedef is in types.h but we want the documentation here */
> #if 0
> /**
> --
> 2.43.0
>