Re: [PATCH v2 1/4] dev_printk: add new dev_err_probe() helpers

Nuno Sá
2024-05-02T11:34:25Z

On Tue, 2024-04-23 at 18:31 +0300, Andy Shevchenko wrote:
> On Tue, Apr 23, 2024 at 05:20:30PM +0200, Nuno Sa via B4 Relay wrote:
> > From: Nuno Sa <nuno.sa@analog.com>
> >
> > This is similar to dev_err_probe() but for cases where an ERR_PTR() or
> > ERR_CAST() is to be returned simplifying patterns like:
> >
> > dev_err_probe(dev, ret, ...);
> > return ERR_PTR(ret)
> > or
> > dev_err_probe(dev, PTR_ERR(ptr), ...);
> > return ERR_CAST(ptr)
>
> ...
>
> > +/* Simple helper for dev_err_probe() when ERR_PTR() is to be returned. */
> > +#define dev_err_ptr_probe(dev, ___err, fmt, ...) ({ \
> > + ERR_PTR(dev_err_probe(dev, ___err, fmt, ##__VA_ARGS__)); \
> > +})
>
> Why ; and hence why ({}) ?
>
> I even believe the compiler may warn if you have double ;; in some cases.
>

Oh yes, no need for any of those...

- Nuno Sá