Re: [PATCH v2 1/4] dev_printk: add new dev_err_probe() helpers

Andy Shevchenko
2024-04-23T15:45:36Z

On Tue, Apr 23, 2024 at 06:31:20PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 23, 2024 at 05:20:30PM +0200, Nuno Sa via B4 Relay wrote:
> > From: Nuno Sa <nuno.sa@analog.com>

...

> > +#define dev_err_cast_probe(dev, ___err_ptr, fmt, ...) ({ \
> > + ERR_PTR(dev_err_probe(dev, PTR_ERR(___err_ptr), fmt, ##__VA_ARGS__)); \
> > +})

After looking into the next patch I think this should be rewritten to use %pe,
hence should be an exported function. Or dev_err_probe() should be split to
a version that makes the difference between int and const void * (maybe using
_Generic()).

--
With Best Regards,
Andy Shevchenko