Re: [PATCH v4] PCI: Relabel JHL6540 on Lenovo X1 Carbon 7,8

Mika Westerberg
2024-05-16T08:30:21Z

Hi,

On Wed, May 15, 2024 at 10:35:22PM +0200, Lukas Wunner wrote:
> On Wed, May 15, 2024 at 02:53:54PM -0400, Esther Shimanovich wrote:
> > On Wed, May 8, 2024 at 1:23???AM Lukas Wunner <lukas@wunner.de> wrote:
> > > On Wed, May 01, 2024 at 06:23:28PM -0400, Esther Shimanovich wrote:
> > > > On Sat, Apr 27, 2024 at 3:17AM Lukas Wunner <lukas@wunner.de> wrote:
> > > > That is correct, when the user-visible issue occurs, no driver is
> > > > bound to the NHI and XHCI. The discrete JHL chip is not permitted to
> > > > attach to the external-facing root port because of the security
> > > > policy, so the NHI and XHCI are not seen by the computer.
> > >
> > > Could you rework your patch to only rectify the NHI's and XHCI's
> > > device properties and leave the bridges untouched?
> >
> > So I tried a build with that patch, but it never reached the
> > tb_pci_fixup function
>
> That means that for some reason, the PCI devices are not associated with
> the Thunderbolt ports. Could you add this to the command line:
>
> thunderbolt.dyndbg ignore_loglevel log_buf_len=10M
>
> and this to your kernel config:
>
> CONFIG_DYNAMIC_DEBUG=y
>
> You should see "... is associated with ..." messages in dmesg.
> This did work for Mika during his testing with recent Thunderbolt chips.
> I amended the patches after his testing but wouldn't expect that to
> cause issues.
>
> @Mika, would you mind re-testing if you've got cycles to spare?

Sure, I'll try this today and update.