From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 440E515FA82 for ; Wed, 24 Apr 2024 15:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713972789; cv=none; b=lktIpjVjlvqmIBOfuw2OrYIcrdU8sqG28SCPQib5wHA4JQVXaExJzW7/ijj/wFWMq67xJwFTEX5IJE1vexI6EkRuzpeZDiNeL7YiD8XVnQhYcnbA9KpaKQhMpxXjA62vXmpD0c2rlaqL7hadNAF93xmGSkHCfDvztCQ41KuGmO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713972789; c=relaxed/simple; bh=Sa2jolD7DuYxzvUq65yIMPq5BeIoPzrBy772nMd05UU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SPPWpsRARNZ3Z5H93EIzcyCAfGH6gKbr2ZKkk9Pf3ch+oMs3KUr9xLF/dGD1ppFlC3dpLdCahKhrO3M0g/TnAYLLl+FvG0GARtjTT/8/Yz+4hX6WXzPlSxUrcwi8y/Mov7mjLnEaVaAeb4aolVOU3PV8q7byZu0y0iY9a9CFmTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rrueLUni; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rrueLUni" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5f415fd71f8so5238078a12.3 for ; Wed, 24 Apr 2024 08:33:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713972786; x=1714577586; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=DJOm+lWo+hp1zepsogWn2+mB5g4PZtqtai6pqqXOLRo=; b=rrueLUni32kD+DHer4P4P1zDdnzpi2RWSRNVGlrBAYxFkMHWNHDUsxARjPazCNpNvQ cHSmZ+MOa4L3zhwMnTrd24S9w/10Wp2LgGipOCYd6NA0BWN+8DODiV/yr0k8wZGvUBz2 VZ5a2ijMM7paTyC/fsh9kmnuJgT6o6pf/vFAQ+1cY2ebpnNz6CdHHNl50LE1TT0YNJCN RuaoNIZWW+hXh2+u30U+9m+PumF7z0CUeFng0tuiyYL7NhcOMnJ+2sMOd33txvaN1MM3 iLE4ao5zicqCcYf08cyWWsEGZX65eeTlsEcfwCSMd3qstQnYyOfsL3cyoTiiCtEsr97m RerA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713972786; x=1714577586; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DJOm+lWo+hp1zepsogWn2+mB5g4PZtqtai6pqqXOLRo=; b=e0/ssM5wlrkoVWxRvpyHMJmUQYnxs4bn8FudVymElrHcT8B0M5+qXeJCZyICInz8VG A1nSTPeqiAJDc17lOQQo2zDn6abpzX/kwzLHDTOjkMpg5bEiSpyZjUX3hmvwctWWbKrW ffqKZDQJcu6HQ/KtwySzvEyW+6RRTI36Upyztg7oi7L7w2IJieVXOY34J+p5/svRGjxE eXSjTnR2FkFXMBzuh6rZyXueJSR2Vb2zQEDobZ97qSLAL2pD3DDezJdUfveCL6ExlVyo 6SzaS6ZDbJ3Pyo2FgrTRFPN7OiT2Jo4XzShTvBgj6boFRiiIX9FNMJSXmDVibmFGi6Ar BOFg== X-Forwarded-Encrypted: i=1; AJvYcCW/kPQ5L0Okp3kjYnNfDf68dRB3zD165c5vKOXdmA6id4komejhtfPYD5YSsRoIRCswla63iyMKOPZ+oIX5L1ejMPFoFEBrkl/Gge/F X-Gm-Message-State: AOJu0YxhjDFNREncs4Bfm9/a8l8JcCLPdqkpxjUJkovJvIDyCZw9M6oq kTGzK6m+mVRmy8I2RJHIWLzuiaCmZRk+aJvRvGghZwkQ63ZMHRvSO073CzbZSZpD82xc4xd813w = X-Google-Smtp-Source: AGHT+IF/yDBR9aXI+gweXeu9pphLXlHTJLGWrb0UVPIkQOr3z11HlRqyg+FfZqFhOfn5DkwfZomqBw== X-Received: by 2002:a17:90b:33cf:b0:2a4:752f:b7b7 with SMTP id lk15-20020a17090b33cf00b002a4752fb7b7mr2784956pjb.26.1713972786226; Wed, 24 Apr 2024 08:33:06 -0700 (PDT) Received: from thinkpad ([120.60.135.200]) by smtp.gmail.com with ESMTPSA id gn5-20020a17090ac78500b0029f349cc253sm13086303pjb.54.2024.04.24.08.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 08:33:05 -0700 (PDT) Date: Wed, 24 Apr 2024 21:02:53 +0530 From: 'Manivannan Sadhasivam' To: Shradha Todi Cc: bp@alien8.de, tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org, rric@kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, josh@joshtriplett.org, lukas.bulwahn@gmail.com, hongxing.zhu@nxp.com, pankaj.dubey@samsung.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, vidyas@nvidia.com, gost.dev@samsung.com, alim.akhtar@samsung.com Subject: Re: [PATCH v2 0/3] Add support for RAS DES feature in PCIe DW controller Message-ID: <20240424153253.GA12524@thinkpad> References: <20231130115044.53512-1-shradha.t@samsung.com> <20231130165514.GW3043@thinkpad> <000601da3e07$c39e5e00$4adb1a00$@samsung.com> <20240104055030.GA3031@thinkpad> <0df701da5ff0$df1165a0$9d3430e0$@samsung.com> <20240216134921.GH2559@thinkpad> <120d01da657e$66b9d3b0$342d7b10$@samsung.com> <20240319163315.GD3297@thinkpad> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240319163315.GD3297@thinkpad> On Tue, Mar 19, 2024 at 10:03:15PM +0530, 'Manivannan Sadhasivam' wrote: > On Thu, Feb 22, 2024 at 04:30:47PM +0530, Shradha Todi wrote: > > + Borislav, Tony, James, Mauro, Robert > > > > Hi All, > > > > Synopsys DesignWare PCIe controllers have a vendor specific capability (which > > means that this set of registers are only present in DesignWare controllers) > > to perform debug operations called "RASDES". > > The functionalities provided by this extended capability are: > > > > 1. Debug: This has some debug related diagnostic features like holding LTSSM > > in certain states, reading the status of lane detection, checking if any PCIe > > lanes are broken (RX Valid) and so on. It's a debug only feature used for diagnostic > > use-cases. > > > > 2. Error Injection: This is a way to inject certain errors in PCIe like LCRC, ECRC, > > Bad TLPs and so on. Again, this is a debug feature and generally not used in > > functional use-case. > > > > 3. Statistical counters: This has 3 parts > > - Error counters > > - Non error counters (covered as part of perf [1]) > > - Time based analysis counters (covered as part of perf [1]) > > > > Selective features of the above functionality has been implemented > > by vendor specific PCIe controller drivers (pcie-tegra194.c) that use > > Synopsys DesignWare PCIe controllers. > > In order to make it useful to all vendors using DWC controller, we had > > proposed a common implementation in DWC PCIe controller directory > > (drivers/pci/controller/dwc/) and our original idea was based on debugfs > > filesystem. v1 and v2 are mentioned in [2] and [3]. > > > > We got a suggestion to implement this as part of EDAC framework [3] and > > we looked into the same. But as far as I understood, what I am trying to > > implement is a very specific feature (only valid for Synopsys DWC PCIe controllers). > > This doesn't seem to fit in very well with the EDAC framework and we can > > hardly use any of the EDAC framework APIs. We tried implementing a > > "pci_driver" but since a function driver will already be running on the EP and > > portdrv on the root-complex, we will not be able to bind 2 drivers to a single > > PCI device (root-complex or endpoint). Ultimately, what I will be doing is > > writing a platform driver with debugfs entries which will be present in EDAC > > directory instead of DWC directory. > > > > Can you please help us out by going through this thread [3] and letting us > > know if our understanding is wrong at any point. If you think it is a better > > idea to integrate this in the EDAC framework, can you guide me as > > to how I can utilize the framework better? > > Please let me know if you need any other information to conclude. > > > > [1] https://lore.kernel.org/linux-pci/20231121013400.18367-1-xueshuai@linux.alibaba.com/ > > [2] https://lore.kernel.org/all/20210518174618.42089-1-shradha.t@samsung.com/T/ > > [3] https://lore.kernel.org/all/20231130115044.53512-1-shradha.t@samsung.com/ > > > > Gentle ping for the EDAC maintainers. > Since there is no response from the EDAC maintainers for a while, I think we should go ahead and add the RAS feature in the PCI DWC driver itself. - Mani > - Mani > > > Thanks, > > Shradha > > > > > -----Original Message----- > > > From: 'Manivannan Sadhasivam' > > > Sent: 16 February 2024 19:19 > > > To: Shradha Todi > > > Cc: lpieralisi@kernel.org; kw@linux.com; robh@kernel.org; > > > bhelgaas@google.com; jingoohan1@gmail.com; > > > gustavo.pimentel@synopsys.com; josh@joshtriplett.org; > > > lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; > > > pankaj.dubey@samsung.com; linux-kernel@vger.kernel.org; linux- > > > pci@vger.kernel.org; vidyas@nvidia.com; gost.dev@samsung.com > > > Subject: Re: [PATCH v2 0/3] Add support for RAS DES feature in PCIe DW > > > controller > > > > > > On Thu, Feb 15, 2024 at 02:55:06PM +0530, Shradha Todi wrote: > > > > > > > > > > > > > > [...] > > > > > > > > For the error injection and counters, we already have the EDAC > > > > > framework. So adding them in the DWC driver doesn't make sense to me. > > > > > > > > > > > > > Sorry for late response, was going through the EDAC framework to understand > > > better how we can fit RAS DES support in it. Below are some technical challenges > > > found so far: > > > > 1: This debugfs framework proposed [1] can run on both side of the link i.e. RC > > > and EP as it will be a part of the link controller platform driver. Here for the EP > > > side the assumption is that it has Linux running, which is primarily a use case for > > > chip-to-chip communication. After your suggestion to migrate to EDAC > > > framework we studied and here are the findings: > > > > - If we move to EDAC framework, we need to have RAS DES as a > > > > pci_driver which will be binded based on vendor_id and device_id. Our > > > > observation is that on EP side system we are unable to bind two > > > > function driver (pci_driver), as pci_endpoint_test function driver or > > > > some other chip-to-chip function driver will already be bound. On the > > > > other hand, on RC side we observed that if we have portdrv enabled in > > > > Linux running on RC system, it gets bound to RC controller and then it > > > > does not allow EDAC pci_driver to bind. So basically we see a problem > > > > here, that we can't have two pci_driver binding to same PCI device > > > > 2: Another point is even though we use EDAC driver framework, we may not be > > > able to use any of EDAC framework APIs as they are mostly suitable for memory > > > controller devices sitting on PCI BUS. We will end up using debugfs entries just via > > > a pci_driver placed inside EDAC framework. > > > > > > Please wrap your replies to 80 characters. > > > > > > There is no need to bind the edac driver to VID:PID of the device. The edac driver > > > can be a platform driver and you can instantiate the platform device from the > > > DWC driver. This way, the PCI device can be assocaited with whatever driver, but > > > still there can be a separate edac driver for handling errors. > > > > > > Regarding API limitation, you should ask the maintainer about the possibility of > > > extending them. > > > > > > > > > > > Please let me know if my understanding is wrong. > > > > > > > > > But first check with the perf driver author if they have any plans > > > > > on adding the proposed functionality. If they do not have any plan > > > > > or not working on it, then look into EDAC. > > > > > > > > > > - Mani > > > > > > > > > > > > > Since we already worked and posted patches [1], [2], we will continue to work > > > on this and based on consent from community we will adopt to most suitable > > > framework. > > > > We see many subsystems like ethernet, usb, gpu, cxl having debugfs files that > > > give information about the current status of the running system and as of now > > > based on our findings, we still feel there is no harm in having debugfs entry based > > > support in DesignWare controller driver itself. > > > > > > There is no issue in exposing the debug information through debugfs, that's the > > > sole purpose of the interface. But here, you are trying to add support for DWC > > > RAS feature for which a dedicated framework already exists. > > > > > > And there will be more similar requests coming for vendor specific error protocols > > > as well. So your investigation could benefit everyone. > > > > > > From your above investigation, looks like there are some shortcomings of the > > > EDAC framework. So let's get that clarified by writing to the EDAC maintainers > > > (keep us in CC). If the EDAC maintainer suggests you to add support for this > > > feature in DWC driver itself citing some reasons, then no issues with me. > > > > > > - Mani > > > > > > -- > > > மணிவண்ணன் சதாசிவம் > > > > > > -- > மணிவண்ணன் சதாசிவம் -- மணிவண்ணன் சதாசிவம்