From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
davem@davemloft.net, shuah@kernel.org
Subject: Re: ynl: maybe minor bug?
Date: Wed, 24 Apr 2024 16:43:12 -0700 [thread overview]
Message-ID: <20240424164312.50c4ed2b@kernel.org> (raw)
In-Reply-To: <ZimTlf_ISC2n8snQ@LQ3V64L9R2>
On Wed, 24 Apr 2024 16:19:49 -0700 Joe Damato wrote:
> I'm not sure whether:
>
> 1. tools/net/ynl/lib/ynl.py should be raising NlError when there is an
> extack in this case (I think this is probably the way to go?), or
>
> 2. the tests should be changed so that they don't expect an exception to be
> raised but (ideally?) hide the warning report from tools/net/ynl/lib/ynl.py
> when the warning is expected.
>
> I don't know python at all so this is definitely wrong, but here's a small
> change I made to fix the test (a similar change was made for the test which
> follows).
Sorry about this, we pushed the related fix to the net tree, to get it
to Linus sooner:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=a44f2eb106a46f2275a79de54ce0ea63e4f3d8c8
You can cherry-pick that locally, perhaps. net will get merged into
net-next tomorrow, I should have waited before extending the test :(
prev parent reply other threads:[~2024-04-24 23:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 23:19 ynl: maybe minor bug? Joe Damato
2024-04-24 23:43 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424164312.50c4ed2b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jdamato@fastly.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox