Re: [PATCH 01/10] dt-bindings: pwm: Add SI-EN SN3112 PWM support

Uwe Kleine-König
2024-04-25T06:05:33Z

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Hello,

On Wed, Apr 24, 2024 at 11:29:06PM +0800, Xilin Wu via B4 Relay wrote:
> From: Junhao Xie <bigfoot@classfun.cn>
>
> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller.
>
> Signed-off-by: Junhao Xie <bigfoot@classfun.cn>

Missing S-o-b for patch submitter.

> + "#pwm-cells":
> + const: 1

please use 3 here (which is also what the driver implements)

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]