Re: [PATCH v3 09/14] dt-bindings: fsi: Document the FSI Hub Controller

Krzysztof Kozlowski
2024-04-26T06:26:25Z

On 25/04/2024 23:36, Eddie James wrote:
> Document the FSI Hub Controller CFAM engine.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> ---
> .../bindings/fsi/ibm,hub-fsi-controller.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/fsi/ibm,hub-fsi-controller.yaml
>
> diff --git a/Documentation/devicetree/bindings/fsi/ibm,hub-fsi-controller.yaml b/Documentation/devicetree/bindings/fsi/ibm,hub-fsi-controller.yaml
> new file mode 100644
> index 000000000000..d96d777d4d9f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fsi/ibm,hub-fsi-controller.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fsi/ibm,hub-fsi-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IBM FSI-attached FSI Hub Controller
> +
> +maintainers:
> + - Eddie James <eajames@linux.ibm.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + The FSI Hub Controller is an FSI controller, providing a number of FSI links,
> + located on a CFAM. Therefore this node will always be a child of an FSI CFAM
> + node.
> +
> +properties:
> + compatible:
> + enum:
> + - ibm,hub-fsi-controller

Again, is it for specific chip? SoC? Aren't you using generic
compatibles (not allowed)?

Best regards,
Krzysztof